From: neil@fatboyfat.co.uk (Neil Greatorex)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 for 3.10] Introduce a Marvell EBU MBus driver
Date: Sat, 30 Mar 2013 20:41:20 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.02.1303302040001.13473@vroombuntu> (raw)
In-Reply-To: <20130330202109.GU13280@titan.lakedaemon.net>
On Sat, 30 Mar 2013, Jason Cooper wrote:
> On Thu, Mar 28, 2013 at 10:27:28PM +0000, Neil Greatorex wrote:
> ...
>> -- >8 --
>> Subject: [PATCH] bus: mvebu-mbus: Restore checking for coherency fabric
>> hardware
>>
>> The new mvebu-mbus driver was not checking the device tree for
>> coherency fabric hardware and hence was not setting the hw_io_coherency
>> flag in mbus_state. This prevented the mvsdio driver from operating
>> correctly. This patch restores the check.
>
> Neil,
>
> If I could get you to put a Signed-off-by: on this, I'll queue it up so
> folks can test it more easily.
>
> thx,
>
> Jason.
>
Jason,
Thanks. I've included it below.
Cheers,
Neil
Subject: [PATCH] bus: mvebu-mbus: Restore checking for coherency fabric
hardware
The new mvebu-mbus driver was not checking the device tree for
coherency fabric hardware and hence was not setting the hw_io_coherency
flag in mbus_state. This prevented the mvsdio driver from operating
correctly. This patch restores the check.
Signed-off-by: Neil Greatorex <neil@fatboyfat.co.uk>
---
drivers/bus/mvebu-mbus.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 586d03e..a0250c6 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -858,6 +858,9 @@ int __init mvebu_mbus_init(const char *soc,
phys_addr_t mbuswins_phys_base,
return -ENOMEM;
}
+ if (of_find_compatible_node(NULL, NULL,
"marvell,coherency-fabric"))
+ mbus->hw_io_coherency = 1;
+
for (win = 0; win < mbus->soc->num_wins; win++)
mvebu_mbus_disable_window(mbus, win);
--
1.7.10.4
next prev parent reply other threads:[~2013-03-30 20:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 16:59 [PATCH v3 for 3.10] Introduce a Marvell EBU MBus driver Thomas Petazzoni
2013-03-21 16:59 ` [PATCH v3 1/7] bus: introduce an " Thomas Petazzoni
2013-03-28 19:08 ` Jason Cooper
2013-03-21 16:59 ` [PATCH v3 2/7] arm: mach-mvebu: convert to use mvebu-mbus driver Thomas Petazzoni
2013-03-21 16:59 ` [PATCH v3 3/7] arm: mach-kirkwood: " Thomas Petazzoni
2013-03-21 16:59 ` [PATCH v3 4/7] arm: mach-dove: " Thomas Petazzoni
2013-03-21 16:59 ` [PATCH v3 5/7] arm: mach-orion5x: " Thomas Petazzoni
2013-03-21 16:59 ` [PATCH v3 6/7] arm: mach-mv78xx0: convert to use the " Thomas Petazzoni
2013-03-21 16:59 ` [PATCH v3 7/7] arm: plat-orion: remove addr-map code Thomas Petazzoni
2013-03-30 21:31 ` Jason Cooper
2013-03-21 17:30 ` [PATCH v3 for 3.10] Introduce a Marvell EBU MBus driver Arnd Bergmann
2013-03-21 18:46 ` Jason Cooper
2013-03-28 1:32 ` Neil Greatorex
2013-03-28 1:49 ` Ryan Press
2013-03-28 22:31 ` Neil Greatorex
2013-03-28 7:33 ` Thomas Petazzoni
2013-03-28 22:27 ` Neil Greatorex
2013-03-29 1:00 ` Jason Cooper
2013-03-30 20:21 ` Jason Cooper
2013-03-30 20:41 ` Neil Greatorex [this message]
2013-03-30 21:14 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1303302040001.13473@vroombuntu \
--to=neil@fatboyfat.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox