From: paul@pwsan.com (Paul Walmsley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: omap: hwmod: drop unnecessary list initialization
Date: Mon, 28 Jul 2014 05:24:34 +0000 (UTC) [thread overview]
Message-ID: <alpine.DEB.2.02.1407280524160.24161@utopia.booyaka.com> (raw)
In-Reply-To: <1405455492-1087-1-git-send-email-balbi@ti.com>
On Tue, 15 Jul 2014, Felipe Balbi wrote:
> ml->node and sl->node are currently initialized
> by means of INIT_LIST_HEAD(). That initialiation
> is followed by a list_add() call.
>
> Looking at what both these functions do we will have:
>
> ml->node.next = &ml->node;
> ml->node.prev = &ml->node;
> oi->master->master_ports.next.prev = &ml->node;
> ml->node.next = &oi->master->master_ports.next;
> ml->node.prev = &oi->master->master_ports;
> oi->master->master_ports.next = &ml->node;
>
> from this, it's clear that both INIT_LIST_HEAD() calls
> are unnecessary and can be safely removed.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>
> found by code inspection, boot tested on am437x SK on today's
> linux-next + pending patches.
Thanks, queued for v3.18.
- Paul
next prev parent reply other threads:[~2014-07-28 5:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 20:18 [PATCH] arm: omap: hwmod: drop unnecessary list initialization Felipe Balbi
2014-07-28 5:24 ` Paul Walmsley [this message]
2014-11-04 5:39 ` Felipe Balbi
2014-11-06 16:19 ` Felipe Balbi
2014-11-07 14:09 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1407280524160.24161@utopia.booyaka.com \
--to=paul@pwsan.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox