From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@pwsan.com (Paul Walmsley) Date: Fri, 7 Nov 2014 14:09:55 +0000 (UTC) Subject: [PATCH] arm: omap: hwmod: drop unnecessary list initialization In-Reply-To: <20141106161940.GE16896@saruman> References: <1405455492-1087-1-git-send-email-balbi@ti.com> <20141104053952.GA15760@saruman> <20141106161940.GE16896@saruman> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi On Thu, 6 Nov 2014, Felipe Balbi wrote: > On Mon, Nov 03, 2014 at 11:39:52PM -0600, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jul 28, 2014 at 05:24:34AM +0000, Paul Walmsley wrote: > > > On Tue, 15 Jul 2014, Felipe Balbi wrote: > > > > > > > ml->node and sl->node are currently initialized > > > > by means of INIT_LIST_HEAD(). That initialiation > > > > is followed by a list_add() call. > > > > > > > > Looking at what both these functions do we will have: > > > > > > > > ml->node.next = &ml->node; > > > > ml->node.prev = &ml->node; > > > > oi->master->master_ports.next.prev = &ml->node; > > > > ml->node.next = &oi->master->master_ports.next; > > > > ml->node.prev = &oi->master->master_ports; > > > > oi->master->master_ports.next = &ml->node; > > > > > > > > from this, it's clear that both INIT_LIST_HEAD() calls > > > > are unnecessary and can be safely removed. > > > > > > > > Signed-off-by: Felipe Balbi > > > > --- > > > > > > > > found by code inspection, boot tested on am437x SK on today's > > > > linux-next + pending patches. > > > > > > Thanks, queued for v3.18. > > > > This is not on v3.18, what happened ? > > > > $ git log --author=balbi at ti.com linus/master ^v3.17 -- arch/arm/mach-omap2/omap_hwmod.c > > $ > > ping I wound up not sending any OMAP patches upstream for the v3.18 merge window - instead just acking them. This one has been requeued for v3.19. - Paul