From: wigyori@uid0.hu (Zoltan HERPAI)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: dts: pcduino: Enable user LED and button support for pcDuino
Date: Thu, 8 Jan 2015 16:12:27 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1501081518370.29083@trabant.deployis.eu> (raw)
In-Reply-To: <20150108135953.GU7853@lukather>
Hi Maxime,
On Thu, 8 Jan 2015, Maxime Ripard wrote:
>> + gpio_keys {
>> + compatible = "gpio-keys";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&key_pins_pcduino>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + button at 0 {
>> + label = "Key Back";
>> + linux,code = <KEY_BACK>;
>> + gpios = <&pio 7 17 GPIO_ACTIVE_LOW>;
>> + };
>> + button at 1 {
>> + label = "Key Home";
>> + linux,code = <KEY_HOME>;
>> + gpios = <&pio 7 18 GPIO_ACTIVE_LOW>;
>> + };
>> + button at 2 {
>> + label = "Key Menu";
>> + linux,code = <KEY_MENU>;
>> + gpios = <&pio 7 19 GPIO_ACTIVE_LOW>;
>> + };
>> + };
>
> Some newlines here would have been nice between the button nodes. I
> added them and applied the patch.
First I did it with newlines between the nodes, then spotted that many of
the button specs in other DTSes are without them, so I just removed them.
Thanks for applying anyway!
Regards,
Zoltan H
prev parent reply other threads:[~2015-01-08 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 9:34 [PATCH 1/1] ARM: dts: pcduino: Enable user LED and button support for pcDuino Zoltan HERPAI
2015-01-08 13:59 ` Maxime Ripard
2015-01-08 15:12 ` Zoltan HERPAI [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1501081518370.29083@trabant.deployis.eu \
--to=wigyori@uid0.hu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox