From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@pwsan.com (Paul Walmsley) Date: Wed, 28 Jan 2015 16:25:04 +0000 (UTC) Subject: arm64: USB_ARCH_HAS_EHCI In-Reply-To: <1422438405.5666.16.camel@x220> References: <1422351833.14015.20.camel@x220> <1422438405.5666.16.camel@x220> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 28 Jan 2015, Paul Bolle wrote: > On Tue, 2015-01-27 at 21:31 +0000, Paul Walmsley wrote: > > On Tue, 27 Jan 2015, Paul Bolle wrote: > > > > > Your commit d035fdfa27ac ("arm64: Add Tegra132 support") is included in > > > today's linux-next (ie, next-20150127). I noticed because a script I use > > > to check linux-next spotted a minor problem with it. > > > > > > It adds a select for the Kconfig symbol USB_ARCH_HAS_EHCI. That Kconfig > > > was obsoleted in v3.11 and removed in v3.15. See commit b797b76fb464 > > > ("usb: host: remove USB_ARCH_HAS_?HCI"). That select is now a nop. > > > > > > Should I submit the trivial patch to remove that line or do you prefer > > > to do that yourself? > > > > Thanks, I'll post a new version. > > I just noticed that your commit added another unneeded select. The entry > for ARCH_TEGRA selects HAVE_SMP, but HAVE_SMP is only available on arm > or xtensa. There's no point in selecting it in arm64. OK thanks, will roll that in. Looks like Thierry's already sent a pull request for the original patch, so I'll probably just send a follow-up. Is the Kconfig checker script you mentioned on Tuesday available in the mainline tree? I don't see anything obvious under the "Static Analysers" section of the Makefile, but perhaps I'm overlooking it. - Paul