public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: dinguyen@opensource.altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: socfpga: fix uart DMA binding error
Date: Thu, 19 Feb 2015 11:29:52 -0600	[thread overview]
Message-ID: <alpine.DEB.2.02.1502191118120.20048@linux-builds1> (raw)
In-Reply-To: <1424347672-25075-1-git-send-email-s.trumtrar@pengutronix.de>

On Thu, 19 Feb 2015, Steffen Trumtrar wrote:

> socfpga.dtsi is missing the DMA channels for the uart nodes.
> This will produce the following errors:
> 
> 	of_dma_request_slave_channel: dma-names property of node '/soc/serial0 at ffc02000' missing or empty
> 	ttyS0 - failed to request DMA
> 
> Provide the correct DMA channels to fix this.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  arch/arm/boot/dts/socfpga.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 252c3d1bda50..9d8760956752 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -713,6 +713,9 @@
>  			reg-shift = <2>;
>  			reg-io-width = <4>;
>  			clocks = <&l4_sp_clk>;
> +			dmas = <&pdma 28>,
> +			       <&pdma 29>;
> +			dma-names = "tx", "rx";
>  		};
>  
>  		uart1: serial1 at ffc03000 {
> @@ -722,6 +725,9 @@
>  			reg-shift = <2>;
>  			reg-io-width = <4>;
>  			clocks = <&l4_sp_clk>;
> +			dmas = <&pdma 30>,
> +			       <&pdma 31>;
> +			dma-names = "tx", "rx";
>  		};
>  
>  		rst: rstmgr at ffd05000 {
> -- 
> 2.1.4
> 
> 

Applied to fixes.

BR,
Dinh

      reply	other threads:[~2015-02-19 17:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19 12:07 [PATCH] ARM: socfpga: fix uart DMA binding error Steffen Trumtrar
2015-02-19 17:29 ` Dinh Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1502191118120.20048@linux-builds1 \
    --to=dinguyen@opensource.altera.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox