Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: julia.lawall@lip6.fr (Julia Lawall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support
Date: Tue, 9 Jun 2015 08:10:58 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.02.1506090808500.2069@localhost6.localdomain6> (raw)
In-Reply-To: <557681A7.7080202@monstr.eu>



On Tue, 9 Jun 2015, Michal Simek wrote:

> Hi Paul,
> 
> On 05/22/2015 12:30 PM, Paul Bolle wrote:
> > Again, just a nit: a license mismatch.
> > 
> > On Thu, 2015-05-21 at 22:37 +0530, Kedareswara rao Appana wrote:
> > 
> >> + * This program is free software: you can redistribute it and/or modify
> >> + * it under the terms of the GNU General Public License as published by
> >> + * the Free Software Foundation, either version 2 of the License, or
> >> + * (at your option) any later version.
> > 
> >> +MODULE_LICENSE("GPL v2");
> > 
> > As I said in the message I sent a short while ago: here too I think that
> > either the comment at the top of this file or the ident used in the
> > MODULE_LICENSE() macro needs to change.
> 
> This is not just the problem with this driver but with others too.
> Have you sent any patch to add GPL v2+ to license.h?
> 
> Also sort of checking for this will be great. Julia?

If this requires checking the contents of comment, Coccinelle currently 
can't help with that.  Perhaps an idea would be to just do a grep on the 
file.  So if I find MODULE_LICENSE("GPL v2") and then grepping for "either 
vresion 2" gives success, then there is a problem?  It's obviously not 
foolproof, but perhaps it could be helpful.

julia

  reply	other threads:[~2015-06-09  6:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 17:07 [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support Kedareswara rao Appana
2015-05-22 10:30 ` Paul Bolle
2015-06-08 11:20   ` Appana Durga Kedareswara Rao
2015-06-09  6:03   ` Michal Simek
2015-06-09  6:10     ` Julia Lawall [this message]
2015-06-09  7:09       ` Michal Simek
2015-06-09  8:15         ` Paul Bolle
2015-06-09 10:05           ` Julia Lawall
2015-06-09 10:41           ` Michal Simek
2015-06-09 11:59             ` Paul Bolle
2015-06-09 12:12               ` Michal Simek
2015-06-09 12:24                 ` Paul Bolle
2015-06-09 12:39                   ` Michal Simek
2015-06-09  7:21     ` Paul Bolle
2015-06-09  7:27       ` Michal Simek
2015-06-09  8:08         ` Julia Lawall
2015-06-09  8:27           ` Paul Bolle
2015-06-03  6:22 ` Appana Durga Kedareswara Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1506090808500.2069@localhost6.localdomain6 \
    --to=julia.lawall@lip6.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox