From: dinguyen@opensource.altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on startup
Date: Tue, 5 Apr 2016 13:37:49 -0500 [thread overview]
Message-ID: <alpine.DEB.2.02.1604051333070.32718@linux-builds1> (raw)
In-Reply-To: <20160405053110.GA17541@pd.tnic>
On Tue, 5 Apr 2016, Borislav Petkov wrote:
> On Tue, Apr 05, 2016 at 12:25:33AM -0500, Thor Thayer wrote:
> > I realize that I'm not calling iounmap(ecc_block_base) and I'll fix that in
> > the next revision with a goto.
>
> I'm assuming nothing else changes. Because I've applied 1-4 already.
>
> Yes, no?
>
> If no, then please send only an updated version of this patch as a reply
> to this thread here.
>
My only suggestion was to change the 3 helper functions(ecc_set_bits,
ecc_clear_bits, and ecc_test_bits) should be static inline.
So with that change:
Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com>
BR,
Dinh
next prev parent reply other threads:[~2016-04-05 18:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 18:48 [PATCHv2 0/7] Add Altera Arria10 OCRAM EDAC support tthayer at opensource.altera.com
2016-03-31 18:48 ` [PATCHv2 1/7] EDAC, altera: New file operations for Arria10 ECC modules tthayer at opensource.altera.com
2016-03-31 18:48 ` [PATCHv2 2/7] EDAC, altera: Add register offset for ECC Enable tthayer at opensource.altera.com
2016-03-31 18:48 ` [PATCHv2 3/7] EDAC, altera: Make OCRAM ECC dependency check generic tthayer at opensource.altera.com
2016-03-31 18:48 ` [PATCHv2 4/7] Documentation: dt: socfpga: Add Altera Arria10 OCRAM binding tthayer at opensource.altera.com
2016-04-04 5:15 ` Rob Herring
2016-03-31 18:48 ` [PATCHv2 5/7] EDAC, altera: Addition of Arria10 OCRAM ECC tthayer at opensource.altera.com
2016-03-31 18:48 ` [PATCHv2 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on startup tthayer at opensource.altera.com
2016-04-05 5:25 ` Thor Thayer
2016-04-05 5:31 ` Borislav Petkov
2016-04-05 18:37 ` Dinh Nguyen [this message]
2016-04-05 20:15 ` Borislav Petkov
2016-04-07 0:36 ` Thor Thayer
2016-04-07 11:10 ` Borislav Petkov
2016-03-31 18:48 ` [PATCHv2 7/7] ARM: dts: Add Altera Arria10 OCRAM EDAC devicetree entry tthayer at opensource.altera.com
2016-04-05 18:44 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1604051333070.32718@linux-builds1 \
--to=dinguyen@opensource.altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox