From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] irqchip: gic: always mask interrupts during suspend
Date: Wed, 11 Jun 2014 01:34:39 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1406110129270.5170@nanos> (raw)
In-Reply-To: <1402442098-21093-1-git-send-email-computersforpeace@gmail.com>
On Tue, 10 Jun 2014, Brian Norris wrote:
> Other random thought: it seems like any irqchip driver which does lazy IRQ
> masking ought to use IRQCHIP_MASK_ON_SUSPEND. So maybe the IRQ core should just
> do something like:
>
> if (!chip->irq_disable)
> chip->flags |= IRQCHIP_MASK_ON_SUSPEND;
No. Lazy irq disable and the suspend logic are different beasts.
That's up to the platform to decide this. Just for the record: there
is a world outside of ARM...
But that brings me to a different question:
Why are you not putting that customization into the device tree
instead of trying to add this to some random arch/arm/mach-foo
files?
Thanks,
tglx
next prev parent reply other threads:[~2014-06-10 23:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 23:14 [RFC] irqchip: gic: always mask interrupts during suspend Brian Norris
2014-06-10 23:34 ` Thomas Gleixner [this message]
2014-06-10 23:48 ` Brian Norris
2014-06-11 15:31 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1406110129270.5170@nanos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox