From: julia.lawall@lip6.fr (Julia Lawall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] uhci-platform: use devm_ioremap resource
Date: Wed, 11 Jun 2014 22:03:02 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.10.1406112202450.2576@hadrien> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1406111639420.890-100000@iolanthe.rowland.org>
On Wed, 11 Jun 2014, Alan Stern wrote:
> On Wed, 11 Jun 2014, Julia Lawall wrote:
>
> > > > v2: pass correct arguments to devm_ioremap_resource
> > > > Not compile tested due to incompatible architecture.
> > >
> > > uhci-platform is compatible with all architectures. But you have to
> > > add it to the .config file by hand.
> >
> > What should one do exactly? I added
> >
> > CONFIG_USB_UHCI_PLATFORM=y
> >
> > to the end of my .config file, but then running make just overwrites it:
>
> By golly, you're right... I didn't realize it would do that.
>
> I guess you have to edit the drivers/usb/host/Kconfig file, changing
>
> config USB_UHCI_PLATFORM
> bool
> default y if ARCH_VT8500
>
> to
>
> config USB_UHCI_PLATFORM
> bool
> default y
>
> or something equivalent.
>
> >
> > > make drivers/usb/host/uhci-platform.o
> > scripts/kconfig/conf --silentoldconfig Kconfig
> > #
> > # configuration written to .config
> > #
> > CHK include/config/kernel.release
> > CHK include/generated/uapi/linux/version.h
> > CHK include/generated/utsrelease.h
> > CALL scripts/checksyscalls.sh
> > CC drivers/usb/host/uhci-platform.o
> > drivers/usb/host/uhci-platform.c:13:38: warning: ?struct usb_hcd? declared
> > inside parameter list [enabled by default]
> > static int uhci_platform_init(struct usb_hcd *hcd)
>
> Do
>
> make drivers/usb/host/uhci-hcd.o
>
> instead of
>
> make drivers/usb/host/uhci-platform.o
OK, thanks for the explanations.
julia
prev parent reply other threads:[~2014-06-11 21:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 19:18 [PATCH v2] uhci-platform: use devm_ioremap resource Himangi Saraogi
2014-06-11 19:32 ` Alan Stern
2014-06-11 19:40 ` Julia Lawall
2014-06-11 20:45 ` Alan Stern
2014-06-11 21:03 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1406112202450.2576@hadrien \
--to=julia.lawall@lip6.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox