Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: use cpu_online_mask when using forced irq_set_affinity
Date: Thu, 28 Aug 2014 11:32:52 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1408281130140.23342@nanos> (raw)
In-Reply-To: <53FCA570.1090809@arm.com>

On Tue, 26 Aug 2014, Sudeep Holla wrote:
> > > Can provide your thoughts on how to solve this issue ?
> > 
> > ffde1de64012 is not about offlining a cpu, it's about onlining where
> > we need to make sure that we assign the affinity to a not yet online
> > marked cpu.
> > 
> > > Is it expected from all the irqchip implementation to use force flag in
> > > irq_set_affinity to ignore cpu_online_mask similar to GIC ?
> > 
> > No, it's only relevant for the cases where we need to route irqs to
> > not yet online cpus.
> > 
> 
> Ok. IIUC Russell's main concern was if irqchip implementation uses force
> flag differently, then we can't change the core code to false. Also
> x86 core code also uses forced irq_set_affinity in arch/x86/kernel/irq.c

Which is pointless as none of the x86 irq chip implementations
actually honours the force argument.

In fact until the point where I implemented it in the GIC driver,
nothing ever used that argument. So the GIC conversion actually added
semantics to the argument. Any driver which will make use of it, has
to follow that now. I'll add documentation to the core code for it ...

Thanks,

	tglx

  reply	other threads:[~2014-08-28  9:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09 16:40 [PATCH] arm: use cpu_online_mask when using forced irq_set_affinity Sudeep Holla
2014-05-23 11:26 ` Sudeep Holla
2014-05-23 12:10 ` Russell King - ARM Linux
2014-05-23 12:51   ` Sudeep Holla
2014-06-20 13:04     ` Sudeep Holla
2014-06-20 15:16       ` Russell King - ARM Linux
2014-07-17  9:58         ` Sudeep Holla
2014-08-25  9:55           ` Thomas Gleixner
2014-08-26 15:19             ` Sudeep Holla
2014-08-28  9:32               ` Thomas Gleixner [this message]
2014-08-28 10:12                 ` Sudeep Holla
2014-08-28 10:16                   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1408281130140.23342@nanos \
    --to=tglx@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox