Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: brian.austin@cirrus.com (Brian Austin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] ASoC: cs42l51: re-add of_match_table pointer
Date: Tue, 28 Oct 2014 15:09:33 -0500	[thread overview]
Message-ID: <alpine.DEB.2.10.1410281502200.28816@heelrod> (raw)
In-Reply-To: <1414512524-24466-2-git-send-email-thomas.petazzoni@free-electrons.com>

On Tue, 28 Oct 2014, Thomas Petazzoni wrote:

>  #include "cs42l51.h"
>  
> +static const struct of_device_id cs42l51_of_match[] = {
> +	{ .compatible = "cirrus,cs42l51", },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, cs42l51_of_match);
> +

Can't this be exported in the codec driver instead of removed?
It seems like it would be duplication for a multi-bus codec to have 
to add it in the bus driver.
For example if/when we add SPI this would have to be duplicated there as 
well right?  And then if we have I2C/SPI/Slimbus/Wireless/etc we would 
have this in all those files.

I believe that is how the cs42xx8 is handled. I will have to check.

Thanks,
Brian

  reply	other threads:[~2014-10-28 20:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 16:08 [PATCH 0/6] ASoC/ARM: move Marvell Armada 370 DB to simple-audio-card Thomas Petazzoni
2014-10-28 16:08 ` [PATCH 1/6] ASoC: cs42l51: re-add of_match_table pointer Thomas Petazzoni
2014-10-28 20:09   ` Brian Austin [this message]
2014-10-28 16:08 ` [PATCH 2/6] ASoC: cs42l51: make driver user-selectable Thomas Petazzoni
2014-10-28 19:50   ` Brian Austin
2014-10-28 22:34   ` Mark Brown
2014-10-28 16:08 ` [PATCH 3/6] ASoC: kirkwood: get rid of armada-370-db driver Thomas Petazzoni
2014-10-28 22:35   ` Mark Brown
2014-10-28 22:54     ` Thomas Petazzoni
2014-10-28 23:07       ` Mark Brown
2014-10-29  8:24         ` Thomas Petazzoni
2014-10-29 10:56           ` Mark Brown
2014-10-28 16:08 ` [PATCH 4/6] ARM: mvebu: remove conflicting muxing on Armada 370 DB Thomas Petazzoni
2014-11-07  3:15   ` Jason Cooper
2014-12-18 18:13     ` Gregory CLEMENT
2014-10-28 16:08 ` [PATCH 5/6] ARM: mvebu: use simple-card DT binding for audio " Thomas Petazzoni
2014-10-28 16:08 ` [PATCH 6/6] ARM: mvebu: update mvebu_v7_defconfig for Armada 370 audio Thomas Petazzoni
2014-11-07  3:17   ` Jason Cooper
2014-10-28 16:23 ` [PATCH 0/6] ASoC/ARM: move Marvell Armada 370 DB to simple-audio-card Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1410281502200.28816@heelrod \
    --to=brian.austin@cirrus.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox