From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] genirq: Allow the irqchip state of an IRQ to be save/restored
Date: Sat, 25 Oct 2014 21:42:05 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1410252136220.5308@nanos> (raw)
In-Reply-To: <alpine.DEB.2.11.1410252131110.5308@nanos>
On Sat, 25 Oct 2014, Thomas Gleixner wrote:
Bah, hit send way too fast :)
> On Sat, 25 Oct 2014, Marc Zyngier wrote:
> > +int irq_get_irqchip_state(unsigned int irq, int state)
get_state(state) does not make sense. get_state(which) probably more
so. And 'which' wants to be an enum btw.
> > + chip_bus_lock(desc);
> > + val = chip->irq_get_irqchip_state(data, state);
>
> Hmm. What's the irq_get_irqchip_state() callback supposed to return?
Either an error code or a boolean value, right? Does not mix very well
I think.
int irq_get_irqchip_state(unsigned int irq, enum xxx which, bool *val)
Might be a more clear interface.
Thanks,
tglx
next prev parent reply other threads:[~2014-10-25 19:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-25 10:14 [PATCH 0/3] genirq: Saving/restoring the irqchip state of an irq line Marc Zyngier
2014-10-25 10:14 ` [PATCH 1/3] genirq: Allow the irqchip state of an IRQ to be save/restored Marc Zyngier
2014-10-25 19:35 ` Thomas Gleixner
2014-10-25 19:42 ` Thomas Gleixner [this message]
2014-10-27 11:47 ` Marc Zyngier
2014-11-19 19:10 ` Bjorn Andersson
2014-10-29 10:12 ` Linus Walleij
2014-10-29 11:17 ` Marc Zyngier
2014-10-31 9:57 ` Linus Walleij
2014-10-25 10:14 ` [PATCH 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state Marc Zyngier
2014-10-29 10:14 ` Linus Walleij
2014-10-29 10:22 ` Marc Zyngier
2014-10-25 10:14 ` [PATCH 3/3] irqchip: GICv3: " Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1410252136220.5308@nanos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox