Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM/ARM64: arch-timer: fix arch_timer_probed logic
Date: Mon, 27 Oct 2014 21:30:13 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1410272129170.5308@nanos> (raw)
In-Reply-To: <544E1F6E.5050704@arm.com>

On Mon, 27 Oct 2014, Marc Zyngier wrote:
> Hi Daniel,
> 
> On 21/10/14 12:12, Daniel Lezcano wrote:
> > On 10/21/2014 01:07 PM, Mark Rutland wrote:
> >> Hi Daniel,
> >>
> >> On Tue, Oct 21, 2014 at 11:58:29AM +0100, Daniel Lezcano wrote:
> >>> On 10/15/2014 05:06 PM, Marc Zyngier wrote:
> >>>> Commit c387f07e6205 (clocksource: arm_arch_timer: Discard unavailable
> >>>> timers correctly) changed the way the driver makes sure both the memory
> >>>> and system-register timers have been probed before finalizing the probing.
> >>>>
> >>>> There is a interesting flaw in this logic that leads to this final step
> >>>> never to be executed. Things seems to work pretty well until something
> >>>> actually needs the data that is produced during this final stage.
> >>>>
> >>>> For example, KVM explodes on the first run of a guest when executed on
> >>>> a platform that has both memory and sysreg nodes (Juno, for example).
> >>>>
> >>>> Just fix the damned logic, and enjoy booting VMs again.
> >>>>
> >>>> Tested on a Juno system.
> >>>>
> >>>> Cc: Sudeep Holla <sudeep.holla@arm.com>
> >>>> Cc: Stephen Boyd <sboyd@codeaurora.org>
> >>>> Cc: Mark Rutland <mark.rutland@arm.com>
> >>>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> >>>> Cc: Christoffer Dall <christoffer.dall@linaro.org>
> >>>> Reported-by: Riku Voipio <riku.voipio@linaro.org>
> >>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> >>>> ---
> >>>
> >>> Applied to my tree. Also for -next.
> >>
> >> Is this going to hit -rc2? This was a regression introduced in -rc1.
> >>
> >> Without this fix we've also lost our high precision sched_clock on arm64
> >> platforms.
> >>
> > 
> > Sure.
> > 
> > Thomas or Ingo,
> > 
> > is it possible to update the tip/urgent branch, so I can send the fixes 
> > against 3.18-rc1 ?
> 
> Any update on this? -rc2 has landed, but arm/arm64 timers are still in a
> rather bad shape. Can this please be merged as an urgent fix?

Daniel, timers/urgent is on rc1 already. Please send your pull request.

Thanks,

	tglx

  reply	other threads:[~2014-10-27 20:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-15 15:06 [PATCH] ARM/ARM64: arch-timer: fix arch_timer_probed logic Marc Zyngier
2014-10-15 15:28 ` Mark Rutland
2014-10-15 15:49   ` Sudeep Holla
2014-10-21 10:58 ` Daniel Lezcano
2014-10-21 11:07   ` Mark Rutland
2014-10-21 11:12     ` Daniel Lezcano
2014-10-27 10:33       ` Marc Zyngier
2014-10-27 20:30         ` Thomas Gleixner [this message]
2014-10-27 21:52           ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1410272129170.5308@nanos \
    --to=tglx@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox