From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch irqdomain: Enhance irq_domain_free_irqs_common() to support parentless irqdomain
Date: Sun, 23 Nov 2014 11:36:28 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1411231135190.6439@nanos> (raw)
In-Reply-To: <alpine.DEB.2.11.1411231132160.6439@nanos>
On Sun, 23 Nov 2014, Thomas Gleixner wrote:
> On Fri, 21 Nov 2014, Jiang Liu wrote:
>
> > Originally irq_domain_free_irqs_common() is designed to be used by
> > irqdomains with parent. But there are desires to reuse for parentless
> > irqdomains for code reduction.
> > So check domain->parent before invoking irq_domain_free_irqs_parent().
> >
> > Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
> > ---
> > Hi Thomas,
> > This patch applies to tip/irq/irqdomain, it helps to reduce code
> > size on ARM. Seems we still have chance to merge it into tip/irq/irqdomain:)
> > Regards!
> > Gerry
> > ---
> > kernel/irq/irqdomain.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> > index 029acf11efed..0449d2869e17 100644
> > --- a/kernel/irq/irqdomain.c
> > +++ b/kernel/irq/irqdomain.c
> > @@ -975,7 +975,8 @@ void irq_domain_free_irqs_common(struct irq_domain *domain, unsigned int virq,
> > if (irq_data)
> > irq_domain_reset_irq_data(irq_data);
> > }
> > - irq_domain_free_irqs_parent(domain, virq, nr_irqs);
> > + if (domain->parent)
> > + irq_domain_free_irqs_parent(domain, virq, nr_irqs);
>
> irq_domain_free_irqs_parent()
> {
> if (domain->parent && domain->parent->ops->free)
> ...
> }
>
> So the above is redundant and does not change anything.
Except that this function gets replaced later in the series and drops
the parent check.
Though we should not put the conditionals on the call sites. We want
the functions handle it.
/me goes fixing.
Thanks,
tglx
next prev parent reply other threads:[~2014-11-23 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 3:23 [Patch irqdomain: Enhance irq_domain_free_irqs_common() to support parentless irqdomain Jiang Liu
2014-11-23 10:33 ` Thomas Gleixner
2014-11-23 10:36 ` Thomas Gleixner [this message]
2014-11-23 13:28 ` Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1411231135190.6439@nanos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox