From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Really fix deadlock with mmap_sem
Date: Sat, 13 Dec 2014 01:13:36 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1412130053480.16494@nanos> (raw)
In-Reply-To: <1418425456-19364-1-git-send-email-sboyd@codeaurora.org>
On Fri, 12 Dec 2014, Stephen Boyd wrote:
> Commit 6314b6796e3c (clk: Don't hold prepare_lock across debugfs
> creation, 2014-09-04) forgot to update one place where we hold
> the prepare_lock while creating debugfs directories. This means
> we still have the chance of a deadlock that the commit was trying
> to fix. Actually fix it by moving the debugfs creation outside
> the prepare_lock.
>
> Reported-by: Russell King - ARM Linux <linux@arm.linux.org.uk>
> Fixes: 6314b6796e3c "clk: Don't hold prepare_lock across debugfs creation"
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> + lockdep_assert_held(clk_debug_lock);
That change is not mentioned in the changelog and seems to be
unrelated to the issue at hand.
Other than that:
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
prev parent reply other threads:[~2014-12-13 0:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 23:04 [PATCH] clk: Really fix deadlock with mmap_sem Stephen Boyd
2014-12-12 23:05 ` Russell King - ARM Linux
2014-12-12 23:24 ` Mike Turquette
2014-12-12 23:26 ` Russell King - ARM Linux
2014-12-16 1:18 ` Mike Turquette
2014-12-13 0:13 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1412130053480.16494@nanos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox