Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent
Date: Fri, 15 May 2015 12:39:22 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1505151237531.4225@nanos> (raw)
In-Reply-To: <1431203982-13217-5-git-send-email-stefan@agner.ch>

On Sat, 9 May 2015, Stefan Agner wrote:
> -	irq_chip_unmask_parent(data);
> +	if (parent->chip->irq_enable)
> +		parent->chip->irq_enable(parent);
> +	else
> +		parent->chip->irq_unmask(parent);

Why are you not creating irq_chip_enable_parent() which would have
been the proper function anyway?

Thanks,

	tglx

  reply	other threads:[~2015-05-15 10:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-09 20:39 [PATCH v6 00/12] ARM: vf610m4: Add Vybrid Cortex-M4 support Stefan Agner
2015-05-09 20:39 ` [PATCH v6 01/12] irqdomain: Add non-hierarchy helper irq_domain_set_info Stefan Agner
2015-05-09 20:39 ` [PATCH v6 02/12] genirq: generic chip: support hierarchy domain Stefan Agner
2015-05-09 20:39 ` [PATCH v6 03/12] irqchip: nvic: support hierarchy irq domain Stefan Agner
2015-05-09 20:39 ` [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent Stefan Agner
2015-05-15 10:39   ` Thomas Gleixner [this message]
2015-05-15 16:01     ` Stefan Agner
2015-05-15 20:29       ` Thomas Gleixner
2015-05-09 20:39 ` [PATCH v6 05/12] ARM: ARMv7M: define size of vector table for Vybrid Stefan Agner
2015-05-09 20:39 ` [PATCH v6 06/12] clocksource: add dependencies for Vybrid pit clocksource Stefan Agner
2015-05-09 20:39 ` [PATCH v6 07/12] ARM: unify MMU/!MMU addruart calls Stefan Agner
2015-05-09 20:39 ` [PATCH v6 08/12] ARM: introduce ARM_SINGLE_ARMV7M for ARMv7-M platforms Stefan Agner
2015-05-09 20:39 ` [PATCH v6 09/12] ARM: efm32: use ARM_SINGLE_ARMV7M Stefan Agner
2015-05-09 20:39 ` [PATCH v6 10/12] ARM: vf610: enable Cortex-M4 configuration on Vybrid SoC Stefan Agner
2015-05-09 20:39 ` [PATCH v6 11/12] ARM: dts: add support for Vybrid running on Cortex-M4 Stefan Agner
2015-05-09 20:39 ` [PATCH v6 12/12] ARM: vf610m4: add defconfig for Linux on Vybrids Cortex-M4 Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1505151237531.4225@nanos \
    --to=tglx@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox