From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] irqchip: dw-apb-ictl: add irq_set_affinity support
Date: Mon, 6 Jul 2015 12:30:01 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1507061228060.3916@nanos> (raw)
In-Reply-To: <1436156141-3674-3-git-send-email-jszhang@marvell.com>
On Mon, 6 Jul 2015, Jisheng Zhang wrote:
> +static int dw_apb_ictl_set_affinity(struct irq_data *d,
> + const struct cpumask *mask_val,
> + bool force)
> +{
> + struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d);
> + struct dw_apb_ictl_priv *priv = gc->private;
> + struct irq_chip *chip = irq_get_chip(priv->parent_irq);
> + struct irq_data *data = irq_get_irq_data(priv->parent_irq);
> +
> + if (chip && chip->irq_set_affinity)
> + return chip->irq_set_affinity(data, mask_val, force);
This is wrong as it lacks proper locking of the parent irq. That needs
to be solved at the core code level in a clean way.
Thanks,
tglx
next prev parent reply other threads:[~2015-07-06 10:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 4:15 [PATCH v3 0/2] irqchip: dw-apb-ictl: add irq_set_affinity support Jisheng Zhang
2015-07-06 4:15 ` [PATCH v3 1/2] irqchip: dw-apb-ictl: add private data structure Jisheng Zhang
2015-07-06 4:15 ` [PATCH v3 2/2] irqchip: dw-apb-ictl: add irq_set_affinity support Jisheng Zhang
2015-07-06 10:30 ` Thomas Gleixner [this message]
2015-07-06 13:10 ` Jisheng Zhang
2015-07-06 13:51 ` Thomas Gleixner
2015-07-06 14:17 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1507061228060.3916@nanos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox