From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources
Date: Sun, 26 Jul 2015 13:48:03 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1507261346250.18576@nanos> (raw)
In-Reply-To: <1437584859-64203-2-git-send-email-shenwei.wang@freescale.com>
On Wed, 22 Jul 2015, Shenwei Wang wrote:
> +static int imx_gpcv2_irq_set_wake(struct irq_data *d, unsigned int on)
> +{
> + struct imx_gpcv2_irq *cd = d->chip_data;
> + unsigned int idx = d->hwirq / 32;
> + unsigned long flags;
> + void __iomem *reg;
> + u32 mask, val;
> +
> + raw_spin_lock_irqsave(&cd->lock.rlock, flags);
Oh no. You need to make cd->lock a raw_spinlock and then use
raw_spin_lock_irqsave() on it. How on earth did you come up with this
hackery?
Thanks,
tglx
next prev parent reply other threads:[~2015-07-26 11:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 17:07 [PATCH v6 0/2] IMX GPCv2 drivers for wakeup source and suspend Shenwei Wang
2015-07-22 17:07 ` [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources Shenwei Wang
2015-07-26 11:48 ` Thomas Gleixner [this message]
2015-07-27 13:58 ` Shenwei Wang
2015-07-27 13:40 ` Shawn Guo
2015-07-27 14:13 ` Shenwei Wang
2015-07-27 14:35 ` Shawn Guo
2015-07-27 14:50 ` Shenwei Wang
2015-07-28 0:47 ` Shawn Guo
2015-07-28 14:24 ` Shenwei Wang
2015-07-22 17:07 ` [PATCH v6 2/2] ARM: imx: Add suspend codes for imx7D Shenwei Wang
2015-07-27 13:28 ` Shawn Guo
2015-07-27 18:24 ` Shenwei Wang
2015-07-28 1:02 ` Shawn Guo
2015-07-28 14:16 ` Shenwei Wang
2015-07-28 14:30 ` Shawn Guo
2015-07-28 15:14 ` Shenwei Wang
2015-07-28 16:39 ` Zhi Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1507261346250.18576@nanos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox