Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] arm: Fix backtrace generation when IPI is masked
Date: Tue, 22 Sep 2015 12:59:00 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1509221258330.5606@nanos> (raw)
In-Reply-To: <1442328005-13661-1-git-send-email-daniel.thompson@linaro.org>

On Tue, 15 Sep 2015, Daniel Thompson wrote:

> Currently on ARM when <SysRq-L> is triggered from an interrupt handler
> (e.g. a SysRq issued using UART or kbd) the main CPU will wedge for ten
> seconds with interrupts masked before issuing a backtrace for every CPU
> except itself.
> 
> The new backtrace code introduced by commit 96f0e00378d4 ("ARM: add
> basic support for on-demand backtrace of other CPUs") does not work
> correctly when run from an interrupt handler because IPI_CPU_BACKTRACE
> is used to generate the backtrace on all CPUs but cannot preempt the
> current calling context.
> 
> This can be fixed by detecting that the calling context cannot be
> preempted and issuing the backtrace directly in this case. Issuing
> directly leaves us without any pt_regs to pass to nmi_cpu_backtrace()
> so we also modify the generic code to call dump_stack() when its
> argument is NULL.
> 
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>

For the genric part.

Acked-by: Thomas Gleixner <tglx@linutronix.de>

  parent reply	other threads:[~2015-09-22 10:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14  9:18 [PATCH] arm: Fix backtrace generation when IPI is masked Daniel Thompson
2015-09-15 11:05 ` [PATCH v2] " Daniel Thompson
2015-09-15 11:30   ` Russell King - ARM Linux
2015-09-15 13:15     ` Daniel Thompson
2015-09-15 13:42       ` Russell King - ARM Linux
2015-09-15 14:40 ` [PATCH v3] " Daniel Thompson
2015-09-16  2:43   ` Hillf Danton
2015-09-22 10:59   ` Thomas Gleixner [this message]
2015-10-03 15:40   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1509221258330.5606@nanos \
    --to=tglx@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox