From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] of: irq: Add support for the new definition of "msi-parent"
Date: Sun, 27 Sep 2015 12:29:14 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1509271226340.4500@nanos> (raw)
In-Reply-To: <5602B994.9080409@cogentembedded.com>
On Wed, 23 Sep 2015, Sergei Shtylyov wrote:
> > - d = irq_find_matching_host(msi_np, DOMAIN_BUS_PLATFORM_MSI);
> > - if (!d)
> > - d = irq_find_host(msi_np);
> > - dev_set_msi_domain(dev, d);
> > + d = irq_find_matching_host(args.np, DOMAIN_BUS_PLATFORM_MSI);
> > + if (!d)
>
> if (!d) {
>
> > + d = irq_find_host(args.np);
> > +
> > + if (d) {
>
> } else {
>
> > + dev_set_msi_domain(dev, d);
> > + return;
> > + }
Errm, no. How is that equivalent?
Marc:
d = foo();
if (!d)
d = bar();
if (d) {
bla(d);
return;
}
Yours:
d = foo();
if (!d) {
d = bar();
} else {
bla(d);
return;
}
Hmm?
Thanks,
tglx
next prev parent reply other threads:[~2015-09-27 10:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 17:52 [PATCH 0/4] of: Handle multi-parent version of msi-parent Marc Zyngier
2015-09-22 17:52 ` [PATCH 1/4] of: Add of_parse_phandle_with_opt_args() helper function Marc Zyngier
2015-09-29 17:28 ` Rob Herring
2015-09-30 9:08 ` Marc Zyngier
2015-09-30 13:57 ` Mark Rutland
2015-09-30 15:39 ` Robin Murphy
2015-09-30 17:18 ` Marc Zyngier
2015-09-22 17:52 ` [PATCH 2/4] of: irq: Add support for the new definition of "msi-parent" Marc Zyngier
2015-09-23 14:39 ` Sergei Shtylyov
2015-09-27 10:29 ` Thomas Gleixner [this message]
2015-09-27 13:02 ` Sergei Shtylyov
2015-09-22 17:52 ` [PATCH 3/4] PCI/MSI: " Marc Zyngier
2015-09-22 17:52 ` [PATCH 4/4] irqchip/gic-v3-its: Parse new version of msi-parent property Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1509271226340.4500@nanos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox