From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: reenable interrupt when handling ptrace breakpoint
Date: Mon, 21 Dec 2015 17:51:22 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1512211749180.28591@nanos> (raw)
In-Reply-To: <20151221104818.GF23092@arm.com>
On Mon, 21 Dec 2015, Will Deacon wrote:
> +static void send_user_sigtrap(int si_code)
> +{
> + struct pt_regs *regs = current_pt_regs();
> + siginfo_t info = {
> + .si_signo = SIGTRAP,
> + .si_errno = 0,
> + .si_code = si_code,
> + .si_addr = (void __user *)instruction_pointer(regs),
> + };
> +
> + if (WARN_ON(!user_mode(regs)))
> + return;
> +
> + preempt_disable();
That doesn't work on RT either. force_sig_info() takes task->sighand->siglock,
which is a 'sleeping' spinlock on RT.
Why would we need to disable preemption here at all? What's the problem of
being preempted or even migrated?
Thanks,
tglx
next prev parent reply other threads:[~2015-12-21 16:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 0:18 [PATCH] arm64: reenable interrupt when handling ptrace breakpoint Yang Shi
2015-12-16 11:13 ` Will Deacon
2015-12-16 20:45 ` Shi, Yang
2015-12-21 10:48 ` Will Deacon
2015-12-21 16:51 ` Thomas Gleixner [this message]
2015-12-21 17:00 ` Will Deacon
2015-12-21 17:27 ` Shi, Yang
2016-01-12 19:59 ` Shi, Yang
2016-01-13 10:26 ` Will Deacon
2016-01-13 17:17 ` Shi, Yang
2016-01-13 17:23 ` Will Deacon
2016-01-13 18:10 ` Shi, Yang
2016-02-05 21:25 ` Shi, Yang
2016-02-11 13:54 ` Will Deacon
2016-02-11 17:29 ` Shi, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1512211749180.28591@nanos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox