From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] gpio: xgene: Enable X-Gene standby GPIO as interrupt controller
Date: Fri, 8 Jan 2016 09:45:22 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1601080942270.3575@nanos> (raw)
In-Reply-To: <1452162428-26839-2-git-send-email-qnguyen@apm.com>
On Thu, 7 Jan 2016, Quan Nguyen wrote:
> -static int apm_gpio_sb_to_irq(struct gpio_chip *gc, u32 gpio)
> +static void xgene_gpio_sb_irq_ack(struct irq_data *d)
> +{
> + struct irq_data *irqdata;
> + struct xgene_gpio_sb *priv = irq_data_get_irq_chip_data(d);
> +
> + irqdata = irq_get_irq_data(priv->gic_virq[d->hwirq]);
> + if (!irqdata || !irqdata->chip)
> + return;
What the heck is this? Why are you looking up some random other irq and fiddle
with its irq chip?
This is a 1:1 mapping from your gpio irq to a gic irq. We have hierarchical
interrupt domains for this.
Thanks,
tglx
next prev parent reply other threads:[~2016-01-08 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 10:27 [PATCH v3 0/3] Enable X-Gene standby GPIO as interrupt controller Quan Nguyen
2016-01-07 10:27 ` [PATCH v3 1/3] gpio: xgene: " Quan Nguyen
2016-01-08 8:45 ` Thomas Gleixner [this message]
2016-01-08 9:07 ` Marc Zyngier
2016-01-07 10:27 ` [PATCH v3 2/3] Documentation: gpio: Update description for X-Gene standby GPIO controller DTS binding Quan Nguyen
2016-01-09 22:28 ` Rob Herring
2016-01-07 10:27 ` [PATCH v3 3/3] arm64: dts: Update X-Gene standby GPIO controller DTS entries Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1601080942270.3575@nanos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox