From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"
Date: Wed, 5 Oct 2016 15:38:52 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1610051538310.8953@nanos> (raw)
In-Reply-To: <1475615720-31047-4-git-send-email-okaya@codeaurora.org>
On Tue, 4 Oct 2016, Sinan Kaya wrote:
> The SCI function was removed in two steps (first refactor and then remove).
> This patch does the revert in one step.
>
> The commit 103544d86976 ("ACPI,PCI,IRQ: reduce resource requirements")
> refactored the original code so that SCI penalty is calculated dynamically
> by the time get_penalty function is called. This patch does a partial
> revert for the SCI functionality only.
>
> The commit 9e5ed6d1fb87 ("ACPI,PCI,IRQ: remove SCI penalize function") is
> for the removal of the function. SCI penalty API was replaced by the
> runtime penalty calculation based on the value of
> acpi_gbl_FADT.sci_interrupt.
>
> The IRQ type does not get updated at the right time for some platforms and
> results in incorrect penalty assignment for PCI IRQs as
> irq_get_trigger_type returns the wrong type.
>
> The register_gsi function delivers the IRQ found in the ACPI table to
> the interrupt controller driver. Penalties are calculated before a
> link object is enabled to find out which interrupt has the least number
> of users. By the time penalties are calculated, the IRQ is not registered
> yet and the API returns the wrong type.
>
> Tested-by: Jonathan Liu <net147@gmail.com>
> Tested-by: Ondrej Zary <linux@rainbow-software.org>
> Link: https://lkml.org/lkml/2016/10/4/283
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2016-10-05 13:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 21:15 [PATCH V2 0/3] ACPI,PCI,IRQ: revert penalty calculation for SCI Sinan Kaya
2016-10-04 21:15 ` [PATCH V2 1/3] Revert "ACPI, PCI, IRQ: reduce static IRQ array size to 16" Sinan Kaya
2016-10-12 22:13 ` [PATCH V2 1/3] Revert "ACPI,PCI,IRQ: " Bjorn Helgaas
2016-10-12 22:46 ` [PATCH V2 1/3] Revert "ACPI, PCI, IRQ: " Sinan Kaya
2016-10-13 18:15 ` [PATCH V2 1/3] Revert "ACPI,PCI,IRQ: " Bjorn Helgaas
2016-10-13 19:36 ` [PATCH V2 1/3] Revert "ACPI, PCI, IRQ: " Sinan Kaya
2016-10-13 20:02 ` [PATCH V2 1/3] Revert "ACPI,PCI,IRQ: " Bjorn Helgaas
2016-10-13 20:16 ` [PATCH V2 1/3] Revert "ACPI, PCI, IRQ: " Sinan Kaya
2016-10-13 21:01 ` Rafael J. Wysocki
2016-10-15 3:50 ` Sinan Kaya
2016-10-04 21:15 ` [PATCH V2 2/3] ACPI, PCI IRQ: add PCI_USING penalty for ISA interrupts Sinan Kaya
2016-10-12 19:07 ` Bjorn Helgaas
2016-10-04 21:15 ` [PATCH V2 3/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function" Sinan Kaya
2016-10-05 13:38 ` Thomas Gleixner [this message]
2016-10-13 18:25 ` Bjorn Helgaas
2016-10-11 21:55 ` [PATCH V2 0/3] ACPI,PCI,IRQ: revert penalty calculation for SCI Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610051538310.8953@nanos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox