public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource/arm_global_timer: reconfigure clockevents after cpufreq change
Date: Tue, 29 Nov 2016 14:42:11 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1611291432290.4358@nanos> (raw)
In-Reply-To: <1480421716-30782-2-git-send-email-al.kochet@gmail.com>

On Tue, 29 Nov 2016, Alexander Kochetkov wrote:

> After a cpufreq transition, update the clockevent's frequency
> by fetching the new clock rate from the clock framework and
> reprogram the next clock event.

The frequency change would not only affect the clockevent device, it also
would affect the clocksource. So the patch is incomplete, but see below.

> The clock supplying the arm-global-timer on the rk3188 is coming
> from the the cpu clock itself and thus changes its rate everytime
> cpufreq adjusts the cpu frequency.

That's broken and the clk framework should keep the CORE_PERI clock at a
constant rate by reprogramming the divider of the CPU clock.

> Found by code review, real impact not known. Assume what actual
> HZ value will be different from expected on platforms using
> arm-global-timer as clockevent.

Assumptions w/o real impact are a perfect reason not to apply that
patch. This want's a proper proof that the global timer really changes and
this hackery is required, which I seriously doubt.

Thanks,

	tglx

  reply	other threads:[~2016-11-29 13:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 12:15 [PATCH] clocksource/arm_global_timer: reconfigure clockevents after cpufreq change Alexander Kochetkov
2016-11-29 12:15 ` Alexander Kochetkov
2016-11-29 13:42   ` Thomas Gleixner [this message]
2016-11-29 14:05     ` Alexander Kochetkov
2016-11-29 14:09       ` Thomas Gleixner
2016-11-29 14:14     ` Marc Zyngier
2016-11-29 14:32       ` Thomas Gleixner
2016-11-29 14:51         ` Marc Zyngier
2016-11-29 15:04           ` Alexander Kochetkov
2016-11-29 14:51         ` Alexander Kochetkov
2016-11-29 15:07           ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1611291432290.4358@nanos \
    --to=tglx@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox