Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: julia.lawall@lip6.fr (Julia Lawall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: zynqmp: fix itnull.cocci warnings
Date: Fri, 24 Feb 2017 07:48:19 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1702240743040.2095@hadrien> (raw)

Iterator variable bound on line 220 cannot be NULL

Generated by: scripts/coccinelle/iterators/itnull.cocci

CC: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

tree:   https://github.com/Xilinx/linux-xlnx master
head:   1741e191412444e3ab3308b407a9328186c248e4
commit: 75b49bd76a45208749235a7ba35dba96e3e706f0 [358/384] clk: zynqmp:
Add check for no of users for vpll

Actually, the patch needs to be extended to drop the braces as well.

 clk.c |    2 --
 1 file changed, 2 deletions(-)

--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -218,8 +218,6 @@ static void clk_show_subtree(struct clk_
 		sibling++;

 	hlist_for_each_entry(child, &c->children, child_node) {
-		if (!child)
-			return;
 		clk_show_subtree(child, level + 1);
 	}
 }

                 reply	other threads:[~2017-02-24  6:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1702240743040.2095@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox