From: julia.lawall@lip6.fr (Julia Lawall)
To: linux-arm-kernel@lists.infradead.org
Subject: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'
Date: Sun, 26 Feb 2017 19:03:00 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1702261901180.2056@hadrien> (raw)
In-Reply-To: <1488131271-2908-1-git-send-email-narcisaanamaria12@gmail.com>
On Sun, 26 Feb 2017, Narcisa Ana Maria Vasile wrote:
> This was reported by checkpatch.pl
>
> Signed-off-by: Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Actually, the outreachy tutorial says not to send patches to mailing
lists, only to people (except in the case of IIO, where the maintainers
asked for patches to be sent to mailing lists as well). The
get_maintainer command to use is shown here:
https://kernelnewbies.org/FirstKernelPatch#submit_a_patch
> ---
> drivers/staging/bcm2835-audio/bcm2835-pcm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
> index 9e79236..328bee4a 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835-pcm.c
> +++ b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
> @@ -91,7 +91,7 @@ void bcm2835_playback_fifo(struct bcm2835_alsa_stream *alsa_stream)
> frames_to_bytes(alsa_stream->substream->runtime, alsa_stream->substream->runtime->status->hw_ptr),
> new_period);
> if (alsa_stream->buffer_size) {
> - alsa_stream->pos += consumed &~(1 << 30);
> + alsa_stream->pos += consumed & ~(1 << 30);
> alsa_stream->pos %= alsa_stream->buffer_size;
> }
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe at googlegroups.com.
> To post to this group, send email to outreachy-kernel at googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1488131271-2908-1-git-send-email-narcisaanamaria12%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
next prev parent reply other threads:[~2017-02-26 18:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 17:47 [PATCH] staging: bcm2835-audio: Fixed spacing around '&' Narcisa Ana Maria Vasile
2017-02-26 18:03 ` Julia Lawall [this message]
2017-02-26 18:34 ` [Outreachy kernel] " Joe Perches
2017-02-26 18:59 ` Julia Lawall
2017-02-26 19:37 ` Joe Perches
2017-02-26 19:40 ` Julia Lawall
2017-02-26 21:56 ` Joe Perches
2017-02-27 0:08 ` Scott Branden
2017-02-27 6:25 ` Julia Lawall
2017-02-27 14:44 ` Dan Carpenter
2017-02-27 20:35 ` Scott Branden
2017-02-27 20:47 ` Michael Zoran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1702261901180.2056@hadrien \
--to=julia.lawall@lip6.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox