From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: Schedule affinity_notify work while migrating IRQs during hot plug
Date: Mon, 27 Feb 2017 18:21:20 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1702271818370.4732@nanos> (raw)
In-Reply-To: <a5b146bd9a36dd7b4fe2bc36cbaadade@codeaurora.org>
On Mon, 27 Feb 2017, Sodagudi Prasad wrote:
> So I am thinking that, adding following sched_work() would notify clients.
And break the world and some more.
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 6b66959..5e4766b 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -207,6 +207,7 @@ int irq_do_set_affinity(struct irq_data *data, const
> struct cpumask *mask,
> case IRQ_SET_MASK_OK_DONE:
> cpumask_copy(desc->irq_common_data.affinity, mask);
> case IRQ_SET_MASK_OK_NOCOPY:
> + schedule_work(&desc->affinity_notify->work);
> irq_set_thread_affinity(desc);
> ret = 0;
You cannot do that unconditionally and just slap that schedule_work() call
into the code. Aside of that schedule_work() would be invoked twice for all
calls which come via irq_set_affinity_locked() ....
Thanks,
tglx
next prev parent reply other threads:[~2017-02-27 17:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 20:59 Schedule affinity_notify work while migrating IRQs during hot plug Sodagudi Prasad
2017-02-27 17:12 ` Sodagudi Prasad
2017-02-27 17:21 ` Thomas Gleixner [this message]
2017-03-13 19:43 ` Sodagudi Prasad
2017-03-13 20:19 ` Thomas Gleixner
2017-03-17 10:51 ` Sodagudi Prasad
2017-03-17 13:18 ` Thomas Gleixner
2017-03-20 16:36 ` Prasad Sodagudi
2017-03-20 16:36 ` [PATCH] genirq: Notify clients whenever there is change in affinity Prasad Sodagudi
2017-03-23 2:33 ` kbuild test robot
2017-03-23 6:18 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1702271818370.4732@nanos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox