From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V10 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu irq request
Date: Tue, 20 Jun 2017 16:05:07 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1706201520290.1869@nanos> (raw)
In-Reply-To: <1497275529-23565-1-git-send-email-daniel.lezcano@linaro.org>
On Mon, 12 Jun 2017, Daniel Lezcano wrote:
> But, the API request_percpu_irq does not allow to pass a flag, hence specifying
> if the interrupt type is a timer.
>
> Add a function request_percpu_irq_flags() where we can specify the flags. The
> request_percpu_irq() function is changed to be a wrapper to
> request_percpu_irq_flags() passing a zero flag parameter.
And exactly this change wants to be a separate patch. We do not make whole
sale changes this way. You should know that already and someone pointed
that out to you in some of the earlier versions.
> -int request_percpu_irq(unsigned int irq, irq_handler_t handler,
> - const char *devname, void __percpu *dev_id)
> +int request_percpu_irq_flags(unsigned int irq, irq_handler_t handler,
The function name sucks. The first time I read it, it meant request the per
cpu irq flags, which is not what you aim at, right?
Please make that __request_percpu_irq() for now and on -rc1 time provide a
patch set to convert all current request_percpu_irq() users to have the
extra argument and then remove the __request_percpu_irq() intermediate.
Thanks,
tglx
next prev parent reply other threads:[~2017-06-20 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170612135108.GD2261@mai>
2017-06-12 13:52 ` [PATCH V10 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu irq request Daniel Lezcano
2017-06-20 14:05 ` Thomas Gleixner [this message]
2017-06-20 20:25 ` Daniel Lezcano
2017-06-20 20:29 ` Thomas Gleixner
2017-06-20 20:30 ` Daniel Lezcano
2017-05-16 19:44 Daniel Lezcano
2017-05-17 10:36 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1706201520290.1869@nanos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox