From: julia.lawall@lip6.fr (Julia Lawall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] CLK: SPEAr: make structure field and function argument as const
Date: Tue, 17 Oct 2017 16:42:19 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1710171641400.5035@hadrien> (raw)
In-Reply-To: <1508251114-7042-2-git-send-email-bhumirks@gmail.com>
On Tue, 17 Oct 2017, Bhumika Goyal wrote:
> Make the masks field of clk_aux structure const as it do not modify the
> fields of the aux_clk_masks structure it points to.
>
> Make the struct aux_clk_masks *aux argument of the function
> clk_register_aux as const as the argument is only stored in the masks
> field of a clk_aux structure which is now made const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/clk/spear/clk-aux-synth.c | 2 +-
> drivers/clk/spear/clk.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/spear/clk-aux-synth.c b/drivers/clk/spear/clk-aux-synth.c
> index f271c35..8bea5df 100644
> --- a/drivers/clk/spear/clk-aux-synth.c
> +++ b/drivers/clk/spear/clk-aux-synth.c
> @@ -136,7 +136,7 @@ static int clk_aux_set_rate(struct clk_hw *hw, unsigned long drate,
>
> struct clk *clk_register_aux(const char *aux_name, const char *gate_name,
> const char *parent_name, unsigned long flags, void __iomem *reg,
> - struct aux_clk_masks *masks, struct aux_rate_tbl *rtbl,
> + const struct aux_clk_masks *masks, struct aux_rate_tbl *rtbl,
> u8 rtbl_cnt, spinlock_t *lock, struct clk **gate_clk)
> {
> struct clk_aux *aux;
> diff --git a/drivers/clk/spear/clk.h b/drivers/clk/spear/clk.h
> index 9834944..b9d28b3 100644
> --- a/drivers/clk/spear/clk.h
> +++ b/drivers/clk/spear/clk.h
> @@ -49,7 +49,7 @@ struct aux_rate_tbl {
> struct clk_aux {
> struct clk_hw hw;
> void __iomem *reg;
> - struct aux_clk_masks *masks;
> + const struct aux_clk_masks *masks;
There are spaces before const here.
julia
> struct aux_rate_tbl *rtbl;
> u8 rtbl_cnt;
> spinlock_t *lock;
> @@ -112,7 +112,7 @@ typedef unsigned long (*clk_calc_rate)(struct clk_hw *hw, unsigned long prate,
> /* clk register routines */
> struct clk *clk_register_aux(const char *aux_name, const char *gate_name,
> const char *parent_name, unsigned long flags, void __iomem *reg,
> - struct aux_clk_masks *masks, struct aux_rate_tbl *rtbl,
> + const struct aux_clk_masks *masks, struct aux_rate_tbl *rtbl,
> u8 rtbl_cnt, spinlock_t *lock, struct clk **gate_clk);
> struct clk *clk_register_frac(const char *name, const char *parent_name,
> unsigned long flags, void __iomem *reg,
> --
> 1.9.1
>
>
next prev parent reply other threads:[~2017-10-17 14:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 14:38 [PATCH 0/2] CLK: SPEAr: make structure field, function arg and strutcure const Bhumika Goyal
2017-10-17 14:38 ` [PATCH 1/2] CLK: SPEAr: make structure field and function argument as const Bhumika Goyal
2017-10-17 14:42 ` Julia Lawall [this message]
2017-10-18 3:48 ` Viresh Kumar
2017-11-02 6:22 ` Stephen Boyd
2017-10-17 14:38 ` [PATCH 2/2] CLK: SPEAr: make aux_clk_masks structures const Bhumika Goyal
2017-10-18 3:47 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1710171641400.5035@hadrien \
--to=julia.lawall@lip6.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox