From mboxrd@z Thu Jan 1 00:00:00 1970 From: julia.lawall@lip6.fr (Julia Lawall) Date: Tue, 6 Feb 2018 15:08:21 +0100 (CET) Subject: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask In-Reply-To: <20180206135923.3zthazmsapuzfxra@mwanda> References: <20180205201002.23621-1-wsa+renesas@sang-engineering.com> <20180206131044.oso33fvv553trrd7@mwanda> <20180206132335.luut6em3kut7f7ej@mwanda> <20180206135923.3zthazmsapuzfxra@mwanda> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 6 Feb 2018, Dan Carpenter wrote: > That found 4 that I think Wolfram's grep missed. > > arch/um/drivers/vector_user.h | 2 -- > drivers/gpu/drm/mxsfb/mxsfb_regs.h | 2 -- > drivers/video/fbdev/mxsfb.c | 2 -- > include/drm/drm_scdc_helper.h | 3 --- > > But it didn't find the two bugs that Geert found where the right side > wasn't a number literal. > > drivers/net/can/m_can/m_can.c:#define RXFC_FWM_MASK (0x7f < RXFC_FWM_SHIFT) OK, I can easily add this in - I've got rules to protect against reporting it@the moment. It may end up with false positives. > drivers/usb/gadget/udc/goku_udc.h:#define INT_EPnNAK(n) (0x00100 < (n)) /* 0 < n < 4 */ This is indeed harder, because one has to look@the usage site. julia