From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99B52C04AB4 for ; Mon, 13 May 2019 09:14:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CA1E20989 for ; Mon, 13 May 2019 09:14:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h2ALftQb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CA1E20989 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fz3wMCt/QDZPvhdQd2Id7ozBiPwqi3Z16oQKdMPKubQ=; b=h2ALftQbYtf8Wr 9qOAS86d6HIjhnkf0D2A5M+p0bB63Xmluownc1ZlmeiqrS8MFT7ObiaDsvYHRl+74OH/2D60cBCba fXgBUl2xz2D31CAfG+kmI2qAY637Aiuw2/L1+Bve0P8aaRGme4mxsvS2zwSLSYlLxB05zbTreYhW6 Ka0t9ZbVcffesYMTewpN8nxD+DplVQlvBxUzuI2xJldfYSXN8yW16PsNB1cnKsJ1Q1KENJCKZrJjy paBsnUXOZ7OdJOhM/LnX3CxfR4A4P/vsU8AhngepdA7ezIglPdPTfevffzaDCSrDLqPXEUTA2XJmr Tgnb/08+FaZE8W5R7o6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQ72D-0003EF-8n; Mon, 13 May 2019 09:14:13 +0000 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQ729-0003D6-PI for linux-arm-kernel@lists.infradead.org; Mon, 13 May 2019 09:14:11 +0000 X-IronPort-AV: E=Sophos;i="5.60,465,1549926000"; d="scan'208";a="305784263" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 May 2019 11:00:01 +0200 Date: Mon, 13 May 2019 10:59:57 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Amelie Delaunay Subject: Re: [PATCH] pinctrl: stmfx: Fix comparison of unsigned expression warnings In-Reply-To: <1557732606-14662-1-git-send-email-amelie.delaunay@st.com> Message-ID: References: <1557732606-14662-1-git-send-email-amelie.delaunay@st.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190513_021410_118348_590D7684 X-CRM114-Status: GOOD ( 15.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , Julia Lawall , Linus Walleij , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, kbuild-all@01.org, Maxime Coquelin , Lee Jones , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 13 May 2019, Amelie Delaunay wrote: > This patch fixes the following warnings: > > drivers/pinctrl/pinctrl-stmfx.c:225:5-8: WARNING: Unsigned expression > compared with zero: dir < 0 > drivers/pinctrl/pinctrl-stmfx.c:231:5-9: WARNING: Unsigned expression > compared with zero: pupd < 0 > drivers/pinctrl/pinctrl-stmfx.c:228:5-9: WARNING: Unsigned expression > compared with zero: type < 0 > > Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver") > Reported-by: kbuild test robot > Reported-by: Julia Lawall > Signed-off-by: Amelie Delaunay Acked-by: Julia Lawall > --- > drivers/pinctrl/pinctrl-stmfx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c > index bcd8126..3bd5d6f 100644 > --- a/drivers/pinctrl/pinctrl-stmfx.c > +++ b/drivers/pinctrl/pinctrl-stmfx.c > @@ -213,7 +213,7 @@ static int stmfx_pinconf_get(struct pinctrl_dev *pctldev, > struct stmfx_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev); > u32 param = pinconf_to_config_param(*config); > struct pinctrl_gpio_range *range; > - u32 dir, type, pupd; > + int dir, type, pupd; > u32 arg = 0; > int ret; > > -- > 2.7.4 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel