From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 023DDC10F13 for ; Sun, 14 Apr 2019 16:49:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C82832084E for ; Sun, 14 Apr 2019 16:49:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PgmMufge" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C82832084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sSOA8kxfY8NlL6QrPAAZkLDd2AIvC72FXIlEfb1nCzU=; b=PgmMufgeQ2zlMd sLhZuw75YcxsZNudDaNbPtbb/MNQuqGVjN9MSqtcHkxIVzw/dinvvyOMDDQZHfOIogg0t2a6WKTTp JHphoHdcuPPrB1jOsv7jExcGLNvJzevzMR3s5BODqdFBXgV9rIt6hB0MDssz5j7ZpSobtjB1X62SQ HpBpAzowXn1KrgYpIGwokMV/qSlEFDTRTrm0lRydISMlA9F09MX5ZioevSC8fkcDqm8OPRMFNzD72 avFEu0/dZwbTnH0HjH4lHkClOSNUVGkm0jWCppgLbmZOFIFD3JSYyr78kYVT+yEz80uwtWVfo5sPj w0p4pBFGbH+qVRyoum+g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFiJq-0007uK-7h; Sun, 14 Apr 2019 16:49:26 +0000 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFiJm-0007ta-SJ for linux-arm-kernel@lists.infradead.org; Sun, 14 Apr 2019 16:49:24 +0000 X-IronPort-AV: E=Sophos;i="5.60,350,1549926000"; d="scan'208";a="378569733" Received: from abo-75-106-68.mrs.modulonet.fr (HELO hadrien) ([85.68.106.75]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Apr 2019 18:49:12 +0200 Date: Sun, 14 Apr 2019 18:49:12 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring Subject: Re: [11/12] ARM: OMAP2+: add missing of_node_put after of_device_is_available In-Reply-To: <903ec107-46ed-f19f-56a7-c20031247503@web.de> Message-ID: References: <1550928043-14889-12-git-send-email-Julia.Lawall@lip6.fr> <903ec107-46ed-f19f-56a7-c20031247503@web.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190414_094923_189754_8EE560F9 X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Lindgren , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 14 Apr 2019, Markus Elfring wrote: > > @@ -250,8 +250,10 @@ static int __init omapdss_init_of(void) > > if (!node) > > return 0; > > > > - if (!of_device_is_available(node)) > > + if (!of_device_is_available(node)) { > > + of_node_put(node); > > return 0; > > + } > > > > pdev = of_find_device_by_node(node); > > Is there a need to put the node also in subsequent if branches > for complete exception handling in this function implementation? Yes, it looks like this is indeed missing. I will try to send a better patch when time permits. julia _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel