From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C94D6C0650F for ; Thu, 8 Aug 2019 19:51:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A6A52184E for ; Thu, 8 Aug 2019 19:51:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CTi1ct7r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A6A52184E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SMMvt6lnVj1X+KADdywwMkkz5dnOipECW3YowU2cTkQ=; b=CTi1ct7rN/22bV j90bLAUnYUln6JFMk8PZJU0l7QcK3HCmOP0BgXUbNRP8OW1X0nQaI1qm3abC4BgQn73UKoAvF8ujI yRfY26XKylZrJiDf/7FFQcYfsY69w2cJVNgOiayAHB1/PPHJgacAcGE9Ea4pQl5d6fDstqb53z2XJ XmjiPbJDpGAwDIU0Im3WNVdVaiRWcTFIFT5mzLxJv81y7gHoJo2/Nf0GgSdcML17unxpB0WWjG95l 2dct8b6LIUxhD7LEt6Yxms4St8MISuJdFtAhcBbeX20BR3widR/N5jASrxUlwKOOeMdVm7WHfkwtb DtzjNCL5ePlcI4PrtaKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvoRs-00054r-65; Thu, 08 Aug 2019 19:51:44 +0000 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvoRo-000545-7z for linux-arm-kernel@lists.infradead.org; Thu, 08 Aug 2019 19:51:43 +0000 X-IronPort-AV: E=Sophos;i="5.64,362,1559512800"; d="scan'208";a="394890790" Received: from abo-12-105-68.mrs.modulonet.fr (HELO hadrien) ([85.68.105.12]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 21:51:35 +0200 Date: Thu, 8 Aug 2019 21:51:35 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Stephen Boyd Subject: Re: [PATCH] clk: fix devm_platform_ioremap_resource.cocci warnings In-Reply-To: <20190808194821.825AD21743@mail.kernel.org> Message-ID: References: <20190808194821.825AD21743@mail.kernel.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190808_125141_817998_1A007C59 X-CRM114-Status: UNSURE ( 8.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Michael Turquette , linux-kernel@vger.kernel.org, Philippe Mathieu-Daud?? , bcm-kernel-feedback-list@broadcom.com, kbuild-all@01.org, Jonas Gorski , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 8 Aug 2019, Stephen Boyd wrote: > Quoting Julia Lawall (2019-08-08 09:10:53) > > From: kbuild test robot > > > > drivers/clk/bcm/clk-bcm63xx-gate.c:174:1-9: WARNING: Use devm_platform_ioremap_resource for hw -> regs > > > > Use devm_platform_ioremap_resource helper which wraps > > platform_get_resource() and devm_ioremap_resource() together. > > > > Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci > > > > Fixes: 1c099779c1e2 ("clk: add BCM63XX gated clock controller driver") > > Is it fixing anything? As far as I can tell it's reducing lines of code > with another function. No, it doesn't fix anything. julia > > > CC: Jonas Gorski > > Signed-off-by: kbuild test robot > > Signed-off-by: Julia Lawall > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel