From: Julia Lawall <julia.lawall@lip6.fr>
To: Wambui Karuga <wambui.karugax@gmail.com>
Cc: devel@driverdev.osuosl.org, eric@anholt.net,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com,
bcm-kernel-feedback-list@broadcom.com, wahrenst@gmx.net,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: use DIV_ROUND_UP helper macro
Date: Sun, 13 Oct 2019 21:31:13 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1910132126290.2565@hadrien> (raw)
In-Reply-To: <20191013191027.6470-1-wambui.karugax@gmail.com>
On Sun, 13 Oct 2019, Wambui Karuga wrote:
> Use the DIV_ROUND_UP macro to replace open-coded divisor calculation
> to improve readability.
> Issue found using coccinelle:
> @@
> expression n,d;
> @@
> (
> - ((n + d - 1) / d)
> + DIV_ROUND_UP(n,d)
> |
> - ((n + (d - 1)) / d)
> + DIV_ROUND_UP(n,d)
> )
>
> Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> Changes in v2:
> - Remove comment that explained previously used calculation.
Maybe it is not very important for a comment, but remember that what is
below the --- will disappear in the history. So when actual code changes,
it may be necessary to integrate the extended change in the commit log as
well as putting it in the v2 changes.
julia
> ---
> drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> index 87535a4c2e14..22931ab3a5fc 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> @@ -4156,9 +4156,8 @@ void SetHwReg8723B(struct adapter *padapter, u8 variable, u8 *val)
> break;
> }
>
> - /* The value of ((usNavUpper + HAL_NAV_UPPER_UNIT_8723B - 1) / HAL_NAV_UPPER_UNIT_8723B) */
> - /* is getting the upper integer. */
> - usNavUpper = (usNavUpper + HAL_NAV_UPPER_UNIT_8723B - 1) / HAL_NAV_UPPER_UNIT_8723B;
> + usNavUpper = DIV_ROUND_UP(usNavUpper,
> + HAL_NAV_UPPER_UNIT_8723B);
> rtw_write8(padapter, REG_NAV_UPPER, (u8)usNavUpper);
> }
> break;
> --
> 2.23.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191013191027.6470-1-wambui.karugax%40gmail.com.
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-13 19:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 19:10 [PATCH v2] staging: rtl8723bs: use DIV_ROUND_UP helper macro Wambui Karuga
2019-10-13 19:31 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910132126290.2565@hadrien \
--to=julia.lawall@lip6.fr \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=wahrenst@gmx.net \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox