From: Stefano Stabellini <sstabellini@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Catalin Marinas <catalin.marinas@arm.com>,
xen-devel@lists.xenproject.org, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm64: xen: Use modern annotations for assembly functions
Date: Thu, 19 Dec 2019 13:07:50 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.1912191307410.9832@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <20191219122532.6538-1-broonie@kernel.org>
On Thu, 19 Dec 2019, Mark Brown wrote:
> In an effort to clarify and simplify the annotation of assembly functions
> in the kernel new macros have been introduced. These replace ENTRY and
> ENDPROC. Update the annotations in the xen code to the new macros.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Reviewed-by: Julien Grall <julien@xen.org>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Thank you!
> ---
> arch/arm64/xen/hypercall.S | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/xen/hypercall.S b/arch/arm64/xen/hypercall.S
> index c5f05c4a4d00..5b09aca55108 100644
> --- a/arch/arm64/xen/hypercall.S
> +++ b/arch/arm64/xen/hypercall.S
> @@ -56,11 +56,11 @@
> #define XEN_IMM 0xEA1
>
> #define HYPERCALL_SIMPLE(hypercall) \
> -ENTRY(HYPERVISOR_##hypercall) \
> +SYM_FUNC_START(HYPERVISOR_##hypercall) \
> mov x16, #__HYPERVISOR_##hypercall; \
> hvc XEN_IMM; \
> ret; \
> -ENDPROC(HYPERVISOR_##hypercall)
> +SYM_FUNC_END(HYPERVISOR_##hypercall)
>
> #define HYPERCALL0 HYPERCALL_SIMPLE
> #define HYPERCALL1 HYPERCALL_SIMPLE
> @@ -86,7 +86,7 @@ HYPERCALL2(multicall);
> HYPERCALL2(vm_assist);
> HYPERCALL3(dm_op);
>
> -ENTRY(privcmd_call)
> +SYM_FUNC_START(privcmd_call)
> mov x16, x0
> mov x0, x1
> mov x1, x2
> @@ -109,4 +109,4 @@ ENTRY(privcmd_call)
> */
> uaccess_ttbr0_disable x6, x7
> ret
> -ENDPROC(privcmd_call);
> +SYM_FUNC_END(privcmd_call);
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-19 21:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 12:25 [PATCH v2] arm64: xen: Use modern annotations for assembly functions Mark Brown
2019-12-19 21:07 ` Stefano Stabellini [this message]
2020-01-08 15:55 ` Will Deacon
2020-01-09 15:58 ` Catalin Marinas
2020-01-09 16:33 ` Stefano Stabellini
2020-01-09 16:35 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1912191307410.9832@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=julien@xen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox