From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0204BC433E0 for ; Fri, 22 May 2020 12:59:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB62620723 for ; Fri, 22 May 2020 12:59:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pi5sMhwu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB62620723 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1AWzYACY2ucEF5x4LOaJwGmxf12mXddHIQo4qpXhsm0=; b=pi5sMhwupbwpth thEYn2lMzemxb9eKIqcsEYixHua1NOy7jc45B4ylkua66wozken4vOoip5175ADOvrFN5tK24ev9a +xj2yDQOf6ht2O1XkFgDeTI75Gs146rwp6yyOAmakLOm9CteNljZ9lX0wvYIfuMzuRIA2RIsr/SGf KMJL8QWwapmpCxoil9cS+FTbZALvkyMbApjyf+7Rfh8nk31t5G1aDR/13jsYGb5TGujm8AK0+YmWz 5FIl4/2IeSM5s+J/+6hmnBx8ly+GYReU8iWag0CAMP+FsBKjw0Jx4YnC0g+CeAGMG5ck1ryDC/7VY tFRC8VPH28orKp4If3nQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jc7H1-0001YN-HS; Fri, 22 May 2020 12:59:39 +0000 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jc7Gt-0001WL-Sj; Fri, 22 May 2020 12:59:36 +0000 X-IronPort-AV: E=Sophos;i="5.73,421,1583190000"; d="scan'208";a="450910885" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2020 14:59:22 +0200 Date: Fri, 22 May 2020 14:59:22 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: kbuild-all@lists.01.org, "Andrew-sh.Cheng" , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Rob Herring , Mark Rutland , Matthias Brugger , "Rafael J . Wysocki" , Viresh Kumar , Nishanth Menon , Stephen Boyd , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, "Andrew-sh . Cheng" , srv_heupstream@mediatek.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Saravana Kannan , linux-mediatek@lists.infradead.org, Sibi Sankar , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PM / devfreq: fix odd_ptr_err.cocci warnings In-Reply-To: <20200521160908.GA88022@052716d1a29e> Message-ID: References: <202005220024.mccUgEgn%lkp@intel.com> <20200521160908.GA88022@052716d1a29e> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200522_055932_200776_68F07398 X-CRM114-Status: GOOD ( 17.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, This provides a patch, but it doesn't look like the right one. It looks like the if test should be testing opp_table, julia On Fri, 22 May 2020, kbuild test robot wrote: > From: kbuild test robot > > drivers/devfreq/governor_passive.c:336:7-13: inconsistent IS_ERR and PTR_ERR on line 337. > > PTR_ERR should access the value just tested by IS_ERR > > Semantic patch information: > There can be false positives in the patch case, where it is the call to > IS_ERR that is wrong. > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > CC: Saravana Kannan > Signed-off-by: kbuild test robot > --- > > url: https://github.com/0day-ci/linux/commits/Andrew-sh-Cheng/Add-cpufreq-and-cci-devfreq-for-mt8183-and-SVS-support/20200520-222709 > base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next > :::::: branch date: 26 hours ago > :::::: commit date: 26 hours ago > > Please take the patch only if it's a positive warning. Thanks! > > governor_passive.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/devfreq/governor_passive.c > +++ b/drivers/devfreq/governor_passive.c > @@ -334,7 +334,7 @@ static int cpufreq_passive_register(stru > > opp_table = dev_pm_opp_get_opp_table(cpu_dev); > if (IS_ERR(devfreq->opp_table)) { > - ret = PTR_ERR(opp_table); > + ret = PTR_ERR(devfreq->opp_table); > goto out; > } > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel