From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32CA2C433E0 for ; Thu, 4 Jun 2020 09:53:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED4092074B for ; Thu, 4 Jun 2020 09:52:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f3qV86qn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED4092074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nx1DTe6d07ZUCbHu/oN4UXJyTFoEW8srVChUsOMLEN8=; b=f3qV86qnsTl19z fPUSWMoazI1st7IbgYhBs/Q2hH1MGOm/AkTE9Kh2opoYOPBS3R+IuwYq5qvgO6cnJ3eYOhKNMJZvr rPVS3dxbSoppQqk9s5C7xzDuUm1FxmCWJo2QdSL4tqnw6st3+Z5RmuYR69VhbTkdmFI2byzCQq1fR uPJF+wIFBlIVQ7F2w783e6S4LT8hinrgOL6/nZBLyTkaMR9jjvqWaYziPy1IIkNNJoQE1fKeinZIL vC+zKABcRGLn4PtGTXpDcy5Ql3XOHglR3gfI4/JxpWZvatrHbJi1vMD6KKm680BpZyhDczZAfHuqq wvo+BLB/bHUg41Y+ZwzQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgmYU-0005VK-5K; Thu, 04 Jun 2020 09:52:58 +0000 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgmYQ-0005Ix-JB for linux-arm-kernel@lists.infradead.org; Thu, 04 Jun 2020 09:52:56 +0000 X-IronPort-AV: E=Sophos;i="5.73,471,1583190000"; d="scan'208";a="452941151" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2020 11:52:17 +0200 Date: Thu, 4 Jun 2020 11:52:17 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Joe Perches Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken In-Reply-To: <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> Message-ID: References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> <20200601183102.GS30374@kadam> <20200604083120.GF22511@kadam> <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200604_025254_910110_D538A11C X-CRM114-Status: GOOD ( 23.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Linus Walleij , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Christophe JAILLET , Dan Carpenter , Robert Jarzmik , Daniel Mack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 4 Jun 2020, Joe Perches wrote: > On Thu, 2020-06-04 at 11:31 +0300, Dan Carpenter wrote: > > On Thu, Jun 04, 2020 at 12:08:49AM +0200, Linus Walleij wrote: > [] > > > Fixes means it fixes something that was wrong in that commit. > > > That's all. Whether syntactic or semantic or regression or > > > serious or not does not matter. It is also not compulsory to > > > add it is just helpful. > > > > Fixes tag should be compulsory for actual bug fixes. We had a the > > Bad Binder exploit last year because commit f5cb779ba163 > > ("ANDROID: binder: remove waitqueue when thread exits.") had no Fixes > > tag and wasn't backported to Android kernels. > > Fixes tags IMO should be exclusively for actual bug fixes > and should be mandatory. I'm not sure that it is always possible to determine the specific commit that a patch fixes. Some bugs are too old. Some bugs may arise from an interaction of issues. I don't have a concrete example, but I feel uneasy about mandator and compulsory. Neither word is in the proposed text, though. Should Fixes also be used when the change will make it hard to port other fixes over it? julia > > Perhaps: > --- > Documentation/process/submitting-patches.rst | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst > index 1699b7f8e63a..285a84ae79de 100644 > --- a/Documentation/process/submitting-patches.rst > +++ b/Documentation/process/submitting-patches.rst > @@ -636,12 +636,14 @@ idea was not posted in a public forum. That said, if we diligently credit our > idea reporters, they will, hopefully, be inspired to help us again in the > future. > > -A Fixes: tag indicates that the patch fixes an issue in a previous commit. It > -is used to make it easy to determine where a bug originated, which can help > -review a bug fix. This tag also assists the stable kernel team in determining > -which stable kernel versions should receive your fix. This is the preferred > -method for indicating a bug fixed by the patch. See :ref:`describe_changes` > -for more details. > +A Fixes: tag indicates that the patch fixes a "bug". i.e.: a logic defect or > +regression in a previous commit. A Fixes: tag should not be used to indicate > +that a previous commit had some trivial defect in spelling in the commit log or > +some whitespace defect. The Fixes: tag is used to make it easy to determine > +where a bug originated, which can help review a bug fix. The Fixes: tag also > +assists the stable kernel team in determining which stable kernel versions > +should receive your fix. This is the preferred method for indicating a bug is > +fixed by the patch. See :ref:`describe_changes` for more details. > > .. _the_canonical_patch_format: > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel