From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FAB8C47425 for ; Tue, 29 Sep 2020 12:38:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA8892076A for ; Tue, 29 Sep 2020 12:38:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oLuQVaBI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA8892076A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LmchTUUi4u7HYgI0/utffeQCnjPft3IcwO0N3iGRNzc=; b=oLuQVaBIXSGSgFXKTH1mciAUP 5xLHGzmI1eQpOVJwS6XHsTU600XXkAbYapRhgGTrwwlU4ggq/BNfevh7tYU97+TJzYu49rwR6HwdA quU2w02T3JoAEVXIzeswMHj1Ht7M5VH00E8KKnvCcK6DRL9Z3gYZE7ElVfK5QIQaP9aJ4d5B5etaV IFITBzbM14F2uKAZnAfS00L0w/fD+wTrHoyYK//ivwx0BMS/zjk8fmY+ThWj+yg1lxpSa1SZWrYmy w/r0+XPHGMD//tVzKS3zMUCe5l4qDZIMOQqHubSInxwIIonoZj62OnM1MOLuhj4MWP6QOH8FV874J E3/4WYCLQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNEsT-0005hU-7t; Tue, 29 Sep 2020 12:37:05 +0000 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNEsP-0005gd-Ni; Tue, 29 Sep 2020 12:37:03 +0000 X-IronPort-AV: E=Sophos;i="5.77,318,1596492000"; d="scan'208";a="360346486" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 14:36:52 +0200 Date: Tue, 29 Sep 2020 14:36:52 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Ard Biesheuvel Subject: Re: [PATCH 00/18] use semicolons rather than commas to separate statements In-Reply-To: Message-ID: References: <1601233948-11629-1-git-send-email-Julia.Lawall@inria.fr> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200929_083701_969899_35F75FFB X-CRM114-Status: GOOD ( 23.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, Jerome Brunet , "Rafael J. Wysocki" , linux-stm32@st-md-mailman.stormreply.com, ACPI Devel Maling List , drbd-dev@lists.linbit.com, David Lechner , Martin Blumenstingl , linux-block@vger.kernel.org, linux-amlogic@lists.infradead.org, Thomas Gleixner , Linux ARM , =?UTF-8?Q?Valdis_Kl=C4=93tnieks?= , linux-wireless@vger.kernel.org, Linux Kernel Mailing List , Linux Crypto Mailing List , Joe Perches , openipmi-developer@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 29 Sep 2020, Ard Biesheuvel wrote: > On Sun, 27 Sep 2020 at 21:56, Julia Lawall wrote: > > > > These patches replace commas by semicolons. > > > Why? Among the complete 5000 lines of changes there is one probable bug where an if branch ends with a comma and thus pulls the subsequent statement under the if branch, in contradiction to what is indicated by the indentation. The use of comma often appears to be random, with a sequence of similar statements where some have commas and some don't. >From a self-interested point of view, commas are not good for Coccinelle, because multiple statements are put into one. Any problems involving them are thus likely to be overlooked unless one thinks of looking for them explicitly. As an example, Christophe Jaillet noticed that one sequence of comma assignments would be better written using swap. If one looked for opportunities for using swap in the most obvious way, one wouldn't find it. julia > > > > This was done using the > > Coccinelle semantic patch (http://coccinelle.lip6.fr/) shown below. > > > > This semantic patch ensures that commas inside for loop headers will not be > > transformed. It also doesn't touch macro definitions. > > > > Coccinelle ensures that braces are added as needed when a single-statement > > branch turns into a multi-statement one. > > > > This semantic patch has a few false positives, for variable delcarations > > such as: > > > > LIST_HEAD(x), *y; > > > > The semantic patch could be improved to avoid these, but for the moment > > they have been removed manually (2 occurrences). > > > > // > > @initialize:ocaml@ > > @@ > > > > let infunction p = > > (* avoid macros *) > > (List.hd p).current_element <> "something_else" > > > > let combined p1 p2 = > > (List.hd p1).line_end = (List.hd p2).line || > > (((List.hd p1).line_end < (List.hd p2).line) && > > ((List.hd p1).col < (List.hd p2).col)) > > > > @bad@ > > statement S; > > declaration d; > > position p; > > @@ > > > > S@p > > d > > > > // special cases where newlines are needed (hope for no more than 5) > > @@ > > expression e1,e2; > > statement S; > > position p != bad.p; > > position p1; > > position p2 : > > script:ocaml(p1) { infunction p1 && combined p1 p2 }; > > @@ > > > > - e1@p1,@S@p e2@p2; > > + e1; e2; > > > > @@ > > expression e1,e2; > > statement S; > > position p != bad.p; > > position p1; > > position p2 : > > script:ocaml(p1) { infunction p1 && combined p1 p2 }; > > @@ > > > > - e1@p1,@S@p e2@p2; > > + e1; e2; > > > > @@ > > expression e1,e2; > > statement S; > > position p != bad.p; > > position p1; > > position p2 : > > script:ocaml(p1) { infunction p1 && combined p1 p2 }; > > @@ > > > > - e1@p1,@S@p e2@p2; > > + e1; e2; > > > > @@ > > expression e1,e2; > > statement S; > > position p != bad.p; > > position p1; > > position p2 : > > script:ocaml(p1) { infunction p1 && combined p1 p2 }; > > @@ > > > > - e1@p1,@S@p e2@p2; > > + e1; e2; > > > > @@ > > expression e1,e2; > > statement S; > > position p != bad.p; > > position p1; > > position p2 : > > script:ocaml(p1) { infunction p1 && combined p1 p2 }; > > @@ > > > > - e1@p1,@S@p e2@p2; > > + e1; e2; > > > > @r@ > > expression e1,e2; > > statement S; > > position p != bad.p; > > @@ > > > > e1 ,@S@p e2; > > > > @@ > > expression e1,e2; > > position p1; > > position p2 : > > script:ocaml(p1) { infunction p1 && not(combined p1 p2) }; > > statement S; > > position r.p; > > @@ > > > > e1@p1 > > -,@S@p > > +; > > e2@p2 > > ... when any > > // > > > > --- > > > > drivers/acpi/processor_idle.c | 4 +++- > > drivers/ata/pata_icside.c | 21 +++++++++++++-------- > > drivers/base/regmap/regmap-debugfs.c | 2 +- > > drivers/bcma/driver_pci_host.c | 4 ++-- > > drivers/block/drbd/drbd_receiver.c | 6 ++++-- > > drivers/char/agp/amd-k7-agp.c | 2 +- > > drivers/char/agp/nvidia-agp.c | 2 +- > > drivers/char/agp/sworks-agp.c | 2 +- > > drivers/char/hw_random/iproc-rng200.c | 8 ++++---- > > drivers/char/hw_random/mxc-rnga.c | 6 +++--- > > drivers/char/hw_random/stm32-rng.c | 8 ++++---- > > drivers/char/ipmi/bt-bmc.c | 6 +++--- > > drivers/clk/meson/meson-aoclk.c | 2 +- > > drivers/clk/mvebu/ap-cpu-clk.c | 2 +- > > drivers/clk/uniphier/clk-uniphier-cpugear.c | 2 +- > > drivers/clk/uniphier/clk-uniphier-mux.c | 2 +- > > drivers/clocksource/mps2-timer.c | 6 +++--- > > drivers/clocksource/timer-armada-370-xp.c | 8 ++++---- > > drivers/counter/ti-eqep.c | 2 +- > > drivers/crypto/amcc/crypto4xx_alg.c | 2 +- > > drivers/crypto/atmel-tdes.c | 2 +- > > drivers/crypto/hifn_795x.c | 4 ++-- > > drivers/crypto/talitos.c | 8 ++++---- > > 23 files changed, 60 insertions(+), 51 deletions(-) > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel