Re: [PATCH v2 1/2] ACPI: AGDI: Add AGDI tables to drivers/acpi

From: Ilkka Koskinen <ilkka@os.amperecomputing.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Ilkka Koskinen <ilkka@os.amperecomputing.com>,
	 Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	 Hanjun Guo <guohanjun@huawei.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	 Russell King - ARM Linux <linux@armlinux.org.uk>,
	 Len Brown <lenb@kernel.org>,
	Robert Moore <robert.moore@intel.com>,
	 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	 "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)"
	<devel@acpica.org>,
	 patches@amperecomputing.com, scott@os.amperecomputing.com,
	 darren@os.amperecomputing.com
Subject: Re: [PATCH v2 1/2] ACPI: AGDI: Add AGDI tables to drivers/acpi
Date: Wed, 15 Dec 2021 22:02:32 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2112152159220.6791@ubuntu200401> (raw)
In-Reply-To: <CAJZ5v0jiLfL0k12y5RZ+9LjLqiBMPqRHrqNQGqQ5Le2yOv7QWQ@mail.gmail.com>

On Wed, 15 Dec 2021, Rafael J. Wysocki wrote:

> On Tue, Dec 14, 2021 at 5:41 AM Ilkka Koskinen
> <ilkka@os.amperecomputing.com> wrote:
>>
>> ACPI for Arm Components 1.1 Platform Design Document v1.1 [0] specifices
>> Arm Generic Diagnostic Device Interface (AGDI). It allows an admin to
>> issue diagnostic dump and reset via an SDEI event or an interrupt. This
>> patch adds support to ACPI/AGDI tables.
>>
>> [0] https://developer.arm.com/documentation/den0093/latest/
>>
>> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
>> ---
>>  drivers/acpi/tables.c |  2 +-
>>  include/acpi/actbl2.h | 20 ++++++++++++++++++++
>>  2 files changed, 21 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
>> index 71419eb16e09..5e3169bcb9fb 100644
>> --- a/drivers/acpi/tables.c
>> +++ b/drivers/acpi/tables.c
>> @@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
>>         ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
>>         ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
>>         ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
>> -       ACPI_SIG_NHLT };
>> +       ACPI_SIG_NHLT, ACPI_SIG_AGDI };
>>
>>  #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
>>
>> diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
>> index 71ca090fd61b..66ca85b9f5fe 100644
>> --- a/include/acpi/actbl2.h
>> +++ b/include/acpi/actbl2.h
>
> The changes in actbl2.h are ACPICA material and so they need to be
> routed through the upstream ACPICA project.
>
> Moreover, you have already submitted a pull request with them to the
> upstream: https://github.com/acpica/acpica/pull/737/commits/cf36a6d658ca5aa8c329c2edfc3322c095ffd844
>
> Please wait until this gets integrated and repost the rest of the
> patches as incremental changes on top of that.

Thanks for clarifying the process, that makes sense to me. I'll wait until
the patch gets merged into the kernel and submit what's left from the
patchset as v3 then.

Thanks,
Ilkka

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel