From: Julia Lawall <julia.lawall@inria.fr>
To: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>,
Michal Simek <monstr@monstr.eu>,
Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>,
Tejas Prajapati Rameshchandra <tejaspra@xilinx.com>,
Naga Sureshkumar Relli <nagasure@xilinx.com>,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kbuild-all@lists.01.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: spi-xilinx: fix for_each_child.cocci warnings
Date: Tue, 8 Feb 2022 21:51:30 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2202082148490.52266@hadrien> (raw)
From: kernel test robot <lkp@intel.com>
After for_each_available_child_of_node, of_node_put is needed before break
and return.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
Fixes: 3973536c4560 ("spi: spi-xilinx: Updated axi-qspi controller driver")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head: 1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: 3973536c456079bf3d09e9a97bf33d29422b183f [861/872] spi: spi-xilinx: Updated axi-qspi controller driver
:::::: branch date: 7 days ago
:::::: commit date: 7 days ago
spi-xilinx.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- a/drivers/spi/spi-xilinx.c
+++ b/drivers/spi/spi-xilinx.c
@@ -693,13 +693,16 @@ static int xilinx_spi_probe(struct platf
if (startup_block) {
ret = of_property_read_u32(nc, "reg",
&cs_num);
- if (ret < 0)
+ if (ret < 0) {
+ of_node_put(nc);
return -EINVAL;
+ }
}
ret = of_property_read_u32(nc, "spi-rx-bus-width",
&rx_bus_width);
if (!ret) {
xspi->rx_bus_width = rx_bus_width;
+ of_node_put(nc);
break;
}
}
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2022-02-08 20:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 20:51 Julia Lawall [this message]
2022-02-09 10:33 ` [PATCH] spi: spi-xilinx: fix for_each_child.cocci warnings Ricardo Ribalda Delgado
2022-02-09 13:12 ` Mark Brown
2022-02-09 13:52 ` Ricardo Ribalda Delgado
2022-02-09 13:25 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2022-06-26 14:18 Julia Lawall
2022-06-27 12:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2202082148490.52266@hadrien \
--to=julia.lawall@inria.fr \
--cc=amit.kumar-mahapatra@xilinx.com \
--cc=broonie@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=lakshmi.sai.krishna.potthuri@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=nagasure@xilinx.com \
--cc=ricardo.ribalda@gmail.com \
--cc=shubhrajyoti.datta@xilinx.com \
--cc=tejaspra@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox