From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0C92C433F5 for ; Tue, 19 Apr 2022 23:48:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To: Subject:cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bdjezWduP5KzveY1Ay1exQcGmwxB91DKX/PbH6g+SB0=; b=bIRGIlwaqlp9GLMHrYv++9CW4r 3txyPVpQxgUPQ77laFe05oeWZP2cyeGyuGloEPGIocwWXT5KWkBEz6ToctZGfsJtqorShwIiI8VsR SqqyYtQHUk7TonDvqG3bJY7WiNrkUCgsvzqaUntCIDSP1Cxd2uaQ4iYRDD9bofdfL2cF5b7yNkq4V 62mFbLz5VRI/qIZoNfOYB06ym3sku8I6pENlberqgDND5xYb+nVIlnsCrT/pZn340Lf+l7ZH1EEKV JCmmIMncw3aCr8cX3dJJQ9z4Qg9rQ1G9hZLrxW820OSZsKt/H7Nk6THGUlg3ZmKy51KQuz81HnrRM RZTctuLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngxZN-006dy6-Cl; Tue, 19 Apr 2022 23:47:41 +0000 Received: from mail-dm6nam12on20713.outbound.protection.outlook.com ([2a01:111:f400:fe59::713] helo=NAM12-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngxZK-006dx6-06 for linux-arm-kernel@lists.infradead.org; Tue, 19 Apr 2022 23:47:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V8OpKzOz3HBZOyI9Qx+zWr8MKovRWqSznPAUWUHt277378w7YVwkEXzQyVAJMeVa86/DKSoqeJuAs+kxtAaY2HUNJfA+7X4E7d85PmjdLeRwDkC1rGZQA5/vQp2XGi+syCbiDM1EdwHaacjW5Oq9UMeuF4huIDMnRcO0ZOK7jrGI+PB7WsjbaeCZN6zKWH2NaiElIcFeoGy+sZ2ki3WajyQw+rHziy98koyVBvRlCkWcSIRN6FTiOIQzr3nSe6ab6Nom2Vu3GtbTnAJI17dHVActvedOSPlLO6WwwzibX59soY7S6mhjTuyfGFW22V7toL33MmHIjYmQCk3sQaz5QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MnFiwdwW0zP7EOdw9knbcq+zXeCQyta+KmIPv2tLV24=; b=lmnYrHzpFVKraUiHUWNTS2L8xaLjqYOyDWgw7xs75Od7UQqvC6FbPgbvqO1og2Bt3B+EnsUVDkN3H+AvAIridDBFk/RzdQwX8l07pXrn05/McFKFnRMVcv6OtyCveUEYmnPiM4iaMqdp3WuHvF7FpvfDIhJxd9ROuw0/nVkmHRPoSbn5nxmVr44YrWKjw4/ouCdZJt0Ekxv511/OCqYJrUMRc+4lZz/UKcHAeGzE2Faah1cq/uP/oaMxfYVIWY5JWCvHwqGpSgkzo/9Sly4y1Z48P5iV6aHSDQTLQUlhiF+SCmb+mf66nLvBy+mRg+HB82i2BmIzblxPVvQ5noa1Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MnFiwdwW0zP7EOdw9knbcq+zXeCQyta+KmIPv2tLV24=; b=r7Zj8QZ6fu2KOvqHauvFsw+RBkyYouUOPDVUsAl2kwioC9qQYGj44ccuMgFQYdBhe7t9a7rGxU4TtLFX7hS+7HIpbC/up8btlIfIxIcM+ERRVA85fudG+617ELhhtCjkFkksxGYKw3ELnde9EQ8iss79cQrWxuRM/yTohDlcoo0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from DM5PR0102MB3590.prod.exchangelabs.com (2603:10b6:4:a4::25) by BYAPR01MB4599.prod.exchangelabs.com (2603:10b6:a03:86::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr 2022 23:47:32 +0000 Received: from DM5PR0102MB3590.prod.exchangelabs.com ([fe80::5015:1ef4:46b6:5b34]) by DM5PR0102MB3590.prod.exchangelabs.com ([fe80::5015:1ef4:46b6:5b34%7]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022 23:47:32 +0000 Date: Tue, 19 Apr 2022 16:47:11 -0700 (PDT) From: Ilkka Koskinen X-X-Sender: ikoskine@ubuntu200401 To: Ilkka Koskinen cc: Robin Murphy , will@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/4] perf/arm-cmn: Add CMN-650 support In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) X-ClientProxiedBy: MW4PR03CA0081.namprd03.prod.outlook.com (2603:10b6:303:b6::26) To DM5PR0102MB3590.prod.exchangelabs.com (2603:10b6:4:a4::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a39da1c-1e4e-419d-3a3a-08da225ef8cc X-MS-TrafficTypeDiagnostic: BYAPR01MB4599:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A1DXJd40AFl3OmdROs911g3UAwW/AEKvJ2HQ88asfA9gM5u3o10S/RMaBLerzNRyLSKGyaFbkydjtz5o2uCiTI0LsFt/3EstkcrQ62akkNdnKz7vdvKMKtVLWtnKt4kH6q8L+8E1ThrSLFPvcesnuzwdtVAtPBkws1ekw5xN0oK18287X+O+cBS7ePTFoDQgYSbOm79cO85RFCvHB+L+2FwhdzgiyAu2tfhAfajg8fpBm0hpCeIXg5a20B+J9xSfhaew1jCNdXdtH+LjgzNoFBfZv6oiXLuppzuK3VeEwly87841pbLza9P0a1FVWEZ76InwLCK3gVYm9jAQrOK+/20UawYgoI5UQRLDrT4wKuJ9Nw9xAlwMbuZOUudGpNfjOOlPCuWppFK+4JyVdFBrwNyKktRbGFuaRB+8FjKJ6QXXzMVsRIWdJNiqzF2pdPJErw1jqrXM804qSoK34JEPuQPRCSB+aSLwrWo9RLOAYejtypa17uqdVEAolo9kADJnpvLKsjijy8Ia2wZUoE8PNncSuOBIpxrS66LeII9wCMJWuGVmJRfXehEpZ9X5J2SpU6LMJkneFCrMeaI8ut79GN0gMPlQvTeTTkYgdBRFjlgPeZU5TMa/lTyoOajrRqVd4ahMD+LOuSaZqW+7dP3otD36J5yn9QQKfTRchdYPrcRe/c+70nzLk2pZ77RiWS6PJQgWtbwE3r3s1IMVnE3nJQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR0102MB3590.prod.exchangelabs.com; PTR:; CAT:NONE; SFS:(13230001)(7916004)(4636009)(366004)(6506007)(6512007)(316002)(83380400001)(26005)(38350700002)(52116002)(8936002)(6200100001)(5660300002)(33716001)(2906002)(8676002)(9686003)(6486002)(508600001)(66946007)(66556008)(6862004)(4326008)(86362001)(38100700002)(6666004)(186003)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W5lC9zyRZDJmDBwUSB2/LL7q29Jo2CVE5VqDLmNpvEi+Xwd4MHTUzpQNRN3X?= =?us-ascii?Q?cbdLx71ardQzcxC+btrTwuGBpkhtegqx3MSMu/xPMnwBm+d803+rVEsM069k?= =?us-ascii?Q?Xe2ropX9nPCUEu7sNnnce8sEjXmu2pBSSEK5mt0z30M37VS3ZkHaRTzCcdxa?= =?us-ascii?Q?6Xj57hkaBgJBvO1S1Fl1swm9BqCppdz2Wm5YGokRySqR5tI2m5Zf0KxF8q8m?= =?us-ascii?Q?xOuHppCUU473St3c5kMb6rbAYZm1ZuoZpxg8ABV7cTcvrgDVURtuKTQENUpY?= =?us-ascii?Q?2zqaejwgRQhBXEM2HDMYyaK3d898SQzJ5xjAhrKdVnfVrhuLW3IzD5UWJSUo?= =?us-ascii?Q?JIHNG4TbVFrTyk/K1aryn5/3bTW+x+jgNwB35uDdUKT9p1RKArD+1nG6maYf?= =?us-ascii?Q?qYfaXfpgLzFPEkBtZFmX2UfrP2LcEmJXy3C2Oy285xz4hfYhaxJM2ocHVKz9?= =?us-ascii?Q?N1gs2mJSEZ1rmpfJ56f4jOQNs0WNn7XC2/YgtjH/oBUOHGIOf9toHUg0pnH+?= =?us-ascii?Q?VGERvCXCeTvn6+oFcZrHt3yk3/BXb/EuotHySi/qA6bi4+PU7WaX2mf7AbJv?= =?us-ascii?Q?oXSAmS0vWpleZJXXGvQA2QAisQJ734/lpyATJya1MxOqHK95I4xlYgHD5ITK?= =?us-ascii?Q?VPsOZaRJsPKsZTK5H0gPxi6KHogUNU9CNWYzUWUzojLrWV0k93/zanRd5pjX?= =?us-ascii?Q?+IK51ct+59D6AOwXmfhnioNGAWk1JwUP1WASU1oL5jWADtW+XAR1EBuTc7o/?= =?us-ascii?Q?IpYpPAKA+aTc7fofE1DG7XpZeiQMucgj2fAq5fpgvwvfa+u1FQNVF+EYPms4?= =?us-ascii?Q?rV1o0uv+MZexe4f1KbTSp3eesICiS7ROScglh/7D5lo1u9apjUzeyBu/Hk/O?= =?us-ascii?Q?RYoLL8/GFUd7+NQLGwU48z/yTdER6wAkUITmJn+NJddI7cR0fWdNMQLZqqh7?= =?us-ascii?Q?lNXmY22/I+/VHZGgrYS53O75Duc7uu8/OjbiPrwmf2Vr1DOUx9VLl63A9dB6?= =?us-ascii?Q?4/8Yfruxjb2dpiKwxdexC3LiaLfHq433qKU6VSgwJFvq6P4sYDWiGNFG6Ry8?= =?us-ascii?Q?IvGDJgeIHOnc2qIPQ3JIg7xIXpiGIwAHEY7cBVRy9EWBuDVnD9OfFRnOkVxu?= =?us-ascii?Q?VxHynHhZX05PGCpOS84vrZX2gNkR136m5coGN++kOMG6siSKPl5kWP73G/YJ?= =?us-ascii?Q?60Q3Ykj5LfEBxKUFXmm22AbaMSvUtB6zIrIov/PQ+y85p91FdiPwnti7vovj?= =?us-ascii?Q?l1mNaUgnkf6noolQucYC6WkqP+D3dN4QLAQu/u+BmSlAKSU207eLfykV2BVh?= =?us-ascii?Q?otdduyEvU9wkHW1b5CyNmeAgn0IFeb+9KLsYatpz2oziKz+DPsfO7U9ky/1Y?= =?us-ascii?Q?hPJeKrk8EzuOto9bzyHVDQexf2pdK/ZmeQCF85P6zUVhV2MOEiax6u+54+VG?= =?us-ascii?Q?UdrJ7CkEiwY9c40fbMhlkOyHCZ0lOkkuAagForOUZwBIdoL9lOijHMZtpp+Y?= =?us-ascii?Q?dHHRiEc/SSIgVmXgF3lbv/Mo5MSIcooLSq6hbVpPPmD7Y4aUQchcUqI2SCVQ?= =?us-ascii?Q?L511zQtDG3m7N9iTx8+aWCQbc9e6TxdQZeXWTdFSzg2c8ZgGjPKYSNNHmL2G?= =?us-ascii?Q?urHNfSLu5ldIPNHQZyLZ1EMg8wTGn0vQ7NVg2fnltfaaMEhm+4916mLp1lhc?= =?us-ascii?Q?whpbhdcQ2jueIbZad1V2+mvPjm3VcAa1srtcwkaLIaHbfeAK1bemhRCrFsUY?= =?us-ascii?Q?BcTitZLlHFoCDXKVmJOJhUzXgzXfVVgC8uDggNxwgl+t/On6zUGZ?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a39da1c-1e4e-419d-3a3a-08da225ef8cc X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 23:47:32.3844 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DqYSM+rs47/PD/adK2N3UZlFWN6C62cSGSk1LtUOsGNVM7RUApvE/BrugHWLlaao1INQ6CKElA4I8T6RPQjpujkPVWNLDdTF4YVsMkcSe8axXpoQGRdQWTv6sfLi/juD X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR01MB4599 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_164738_085410_12D7F865 X-CRM114-Status: GOOD ( 20.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 19 Apr 2022, Ilkka Koskinen wrote: > > Hi Robin, > > I need to go through your patches more carefully, but I do have a couple of > comments already: > > On Mon, 18 Apr 2022, Robin Murphy wrote: >> Add the identifiers and events for CMN-650, which slots into its >> evolutionary position between CMN-600 and the 700-series products. >> Imagine CMN-600 made bigger, and with most of the rough edges smoothed >> off, but that then balanced out by some bonkers PMU functionality for >> the new HN-P enhancement in CMN-650r2. >> >> Most of the CXG events are actually common to newer revisions of CMN-600 >> too, so they're arguably a little late; oh well. >> >> Signed-off-by: Robin Murphy >> --- >> drivers/perf/arm-cmn.c | 222 ++++++++++++++++++++++++++++++++--------- >> 1 file changed, 176 insertions(+), 46 deletions(-) >> >> diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c >> index 9c1d82be7a2f..cce8516d465c 100644 >> --- a/drivers/perf/arm-cmn.c >> +++ b/drivers/perf/arm-cmn.c >> @@ -1979,6 +2108,7 @@ MODULE_DEVICE_TABLE(of, arm_cmn_of_match); >> #ifdef CONFIG_ACPI >> static const struct acpi_device_id arm_cmn_acpi_match[] = { >> { "ARMHC600", CMN600 }, >> + { "ARMHC650", CMN650 }, > > Not the great place for this comment but there probably isn't any better. > > Based on DEN0093 v1.1, CMN's DSDT entries have been changed since CMN-600. > ROOTNODEBASE seems to be specific for CMN-600. Moreover, if you compare the > address maps in TRMs' Discovery chapters, you can see the difference. > > I'm thinking, at the minimal the second platform_get_resource() call has to > be skipped and zero returned in arm_cmn600_acpi_probe(), if the model is > cmn650 (probably also for cmn-700) Uh, if only I had read the code more carefully, I had noticed that's what the driver does indeed. Anyway, so far it everything works fine. I test the driver a little more (and review the patches more carefully) and will let know how it goes. --Ilkka _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel