From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D4FEC433F5 for ; Thu, 21 Apr 2022 21:28:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: References:Message-ID:In-Reply-To:Subject:cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7fjrkEf5AhCeW80ypTImzDwAG3d59R5h84MADn+lmAE=; b=bZ6vNNwhTu7vjTC8wYc7XOk92G pboLJJnVBSpPe4HxV4GtX4oOle5u9G1cxCs+SiyPoHzWoe9CtjM/pGqR1I4kZRSAGSi6aFwB5u+cV 1XreTEQMISQDl4hPMQtE5CTXGnFzTaAWYl9sPP7mLgShVIloOqqau8tkFWfj+NbdRP6I1N1GTTDO4 3zzRC5KXDokR6tPahxHMXZo83UGnmMtuawoJI5rK+XKBx1FlqVhmdC2lD7hfXeFQq9BBxQ99HjOHv Nri85sv9V8CKLdBu1ZfegdyqkFR2L1neJOoyBHldh5cFX6SbhHibCxO81HS1IdrawPTCwKrIWVnmc 7DGZfA2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nheKh-00F2iA-4p; Thu, 21 Apr 2022 21:27:23 +0000 Received: from mail-bn8nam08on20716.outbound.protection.outlook.com ([2a01:111:f400:7e8d::716] helo=NAM04-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nheKd-00F2gz-B5 for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 21:27:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fLejnQ2vHlrgEfZuhznocNI05TOyvbX6izQh1ZRXAVr+M/C6jFPchURrOhJekEpkkBJcEcjj85XtXhB+3tn/FtguQJIxiaDzmECwH7AdEGMe4DJ9/A1aqUHlhz4oxIXXyr4DKkl6eVvFGy69EqwdcYzBGreW7+v2YZHi8VuDco+8UCH8ptCx5MUUZtMvd+NE0VLjHIHGWj33BS3d3YxzCLY7AtdOMeNmFcUK145OLfA9//kz+mwwKnvyWUWzkU9UORrTFOQ/DJ7e+cMCgkgdPvEhgW9O78qQtB+srExaTd+oWJS7Fr1SGwdb0uy/oOsmzCNmR5dH/iSvB+dMlpH8Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eeIna1P7R36+6LNpdMX8BXHoqBWG/7x1+qofHtNZViU=; b=jvNGP8jcEGrlhpzGgYNc9wCF/KQo1HJZCNV3iW1S/Ko3x/pN1hzb49UXViS8qX8wfhO1nb/NPTBJh8ZZm5ch0veN8FHZzEjsq2vyb36q+yEns5hSPlHHS/LSdQ8Io58QSAkYMO61Nkkk+ynzbs45HfI0pCCT7Sd7RgQEaAEeh0LIS3qq7rX+wb/zkanNYA1rtBTZZ2MchEoYG6KovHe7xZh5/xa21oNmdEAa/OLn0Hn6w2PuW+YBi2QbWqVSXwYUnvkK7E1nqHzFIws1Cj7obcwPaUupNUFiOze/vukqTghKO2hJZM1fCYpjCOFQj4muNZdIVv+ZcdTn7YV1i+VFsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eeIna1P7R36+6LNpdMX8BXHoqBWG/7x1+qofHtNZViU=; b=ADJRJ18X7uRGRJIZiGvEZ1g3C68PfDQWLP/0zZ4EBpLYZWtCPWiJzj4zXjIya8gxaazsHrJoLEKcInqDSuEAyGSYVgMEYqgAJyX6hY3wsGUDLCaH1cgb9odZXhBnxwag57AjxofDkMdK4+UznWzx1jPwerS+Kmw9MY0lDnVOfAk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from DM5PR0102MB3590.prod.exchangelabs.com (2603:10b6:4:a4::25) by DM8PR01MB7015.prod.exchangelabs.com (2603:10b6:8:18::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr 2022 21:27:13 +0000 Received: from DM5PR0102MB3590.prod.exchangelabs.com ([fe80::5015:1ef4:46b6:5b34]) by DM5PR0102MB3590.prod.exchangelabs.com ([fe80::5015:1ef4:46b6:5b34%7]) with mapi id 15.20.5164.025; Thu, 21 Apr 2022 21:27:12 +0000 Date: Thu, 21 Apr 2022 14:26:53 -0700 (PDT) From: Ilkka Koskinen X-X-Sender: ikoskine@ubuntu200401 To: Robin Murphy cc: Ilkka Koskinen , will@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/4] perf/arm-cmn: Add CMN-650 support In-Reply-To: <3e51c8c1-c753-27ee-7bd2-b50c9306a6c2@arm.com> Message-ID: References: <3e51c8c1-c753-27ee-7bd2-b50c9306a6c2@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Content-Type: multipart/mixed; boundary="2088271309-883279689-1650576432=:3571" X-ClientProxiedBy: MW4P220CA0009.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::14) To DM5PR0102MB3590.prod.exchangelabs.com (2603:10b6:4:a4::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e90c62eb-a7a3-406a-804c-08da23ddb31a X-MS-TrafficTypeDiagnostic: DM8PR01MB7015:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ahs5EjoHzWa7/3m31kYecv7/NzfPGgsPbhHGbJSQvCLgAyQZhJPPF/Amc4cNMKVRkyLUAaG5VYxC090kbV167EaP47zZFN3ImBuqkV+cLQo21uw4PwPj8QjVZOEiRzm6lOEz8db6UrgoE6WojccqPw3samFafzI7qncXP1TMeSM7qwhUzScbjfbIukXzfNISooClPOwDsD/9T80LPbP1sdvc1YPWYKYXTsJSVuzEnNsmk8enpjIfVKXDcvn16TlD81zAPEzdklyj3sfBWr+xRO8/Q6M1Kg6onl9Q3t1wEqWdyCAIpEgNIvSZnzMQdJ3GBRj/TBvQ85y0bthuWB7Ld5V67dw+1BfhdEIrl3xpdd/bJZI+EqoCoR4Rso/OK+XXrUqRDXj4ypy3yxzBP4BQ6Mz2kKp8AP8q34MAdGG9eAQ8DkYqJb4ACFHk5r7opEga8PXVbHd9CobZRnj8RWYGqpToldHw+wf9BOSpp8DTVaF47smmYU43+LKwIue1BKD/B7qUNwgHRmKSetgpXBT4/yOW97nGvK7qHM9CBWiD2uJU5wCa1vLIjBGOrNubzXSaBiExxMV0qVy4J7Z3CjFA/0igEVmMnzaL9eNfLCyMAIWvDisFazmXeIEtZCimqmNlqd9jLJ1ulkmPRpGcm5ixHb3Jc6/Tyqv+fM/tIJiFvPbAfY5nc663kS9iwOjPMWF9UGPw7rM5KyUoIgvZloIQTQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR0102MB3590.prod.exchangelabs.com; PTR:; CAT:NONE; SFS:(13230001)(7916004)(4636009)(366004)(52116002)(26005)(6512007)(9686003)(33964004)(6506007)(53546011)(8936002)(4326008)(316002)(38100700002)(66946007)(8676002)(38350700002)(66556008)(6916009)(66476007)(508600001)(5660300002)(6666004)(86362001)(33716001)(83380400001)(2906002)(6486002)(186003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFovbStzKys1R2NvUTJWOUhBTHQ1YnNSVHkyN2xkSEJHVlhWWFdLR3liekd0?= =?utf-8?B?STdQYktaN2dZQlhNZng3T3JZcWd2Z0xYdUZQbUlEKzFSNU9Yc0wxNzZZcjBQ?= =?utf-8?B?amNwa2diVC9nTStQTGNMdFNNbDczTE15dk4rbzZIT3V5RG1WcmxSYWdKUE14?= =?utf-8?B?VmhjQmE0MDVwTlpKMXo1UGo4S1NpS0U5ZE1WTXd4MG01YkQyUFFmMUYrVkN4?= =?utf-8?B?Z0NXWU5iV2tzMjVsYWplMTZZMzdJdmRzM29WM2lSaVp6emdrOXZXYTJ0L2dB?= =?utf-8?B?T3RkbFRTODZFNEFPZjVZZ2hZYW1CbFh4SnluKzlyUmluaUdQNU1zdnBQdzNx?= =?utf-8?B?VS92YXlRS0NrSUorQmdHTDIySUxQRE1lWG02REdGZ2x4Q0cxTVlxMXRFRVFP?= =?utf-8?B?TWFOZDF6Yk91dmd0MlVMa08wTllhems3N1phcDJTMzhObUw2Ry9jZ3k5eVZh?= =?utf-8?B?MXZzemh0QWdkNGd0Z2xWd3I5OE44RFpFVGMwVVNGMjYwOEllQWliYktKRUQ5?= =?utf-8?B?SWZPMWkwV2w5alY4VmRuTFI3OUJ5cWZyanVMUkdraUNxQ2M1NloySklyajVC?= =?utf-8?B?N09IMkxiRHhEQU91S0puWHZoMnVBU1FrWmdKN3NSUk92empLTnhVY2FvdFFx?= =?utf-8?B?YUhnVnFKT1pRL0ZQOEYwazFhK1cwbG5vNllYM1JLOExFcng1RGlRWVBuT0tK?= =?utf-8?B?ZDFBSCtKdDNacmpybHhwQ3h5ak5qT0paNnErYkhCY2l0MWRNRFdLY0M1cEtq?= =?utf-8?B?aGx6aWJTQTdWaGNsNTlZSXlEUlhvVnp2MWwzSjVXVDR3NGluc3VLS201c0g1?= =?utf-8?B?NmpPVHFzbTl3UGVNZktVZEFsRkNUbEJFMnNvNGY1b0NGZFZDZ3hRSW01S2lT?= =?utf-8?B?eFNXZVpFVHFrZVBMVXNTZlJkZmMyVTNoVEY2K05ydXFMRWNsQW5Yc1lVRU80?= =?utf-8?B?amk1OE9qVi8yVzhEMUM1ejFhZXNPTDhvWXhJc1VqQ1liN2lSWFhSMExhcEtK?= =?utf-8?B?Y0t0bjFwV09TVlpZcURYa0g4bjFHRGlGdjFvdHFSNXNodUFPZ0NYWDk3bGRu?= =?utf-8?B?NWV6emV3OG5RNHRDRys0R1BibjB6Q1JmaWRRNjlNemJWaDJnbm5MS1ZyeWRU?= =?utf-8?B?RW9uKzgyRHBQS3RONVVNb016cDVnL3BXK3RLVSs1eDdjRmZLTFA3bTJYdE8w?= =?utf-8?B?UktTS2toV2ozcEdGbTVROFJaYVo1TVE2VmtXU283cUtPaDhLTStLMERTREVP?= =?utf-8?B?akhGY3hwR1NNN2Nsb0xnVHYzbWUwRzQwR2NsdXI1MWIzU1hIc0srN3MxT0tP?= =?utf-8?B?aHJ4WTRUSXYwOWpTQlc4TUhtL1N2RXFHdTRqeXdBRTdyTHF4aUVSQnVlM1ZH?= =?utf-8?B?aFBoTTdxRlFOVThFYytiN3UyMkVqNGtjUDIrWDYvcmFsRzg1L0NXcW9hdUg5?= =?utf-8?B?K09uN0JTYWpSNEY3N1FnYi9DWU9OcEVmMGc2bUpsVVBpVHdsc0VydUtaRk9y?= =?utf-8?B?aURVeU1Hc1l2QndFVi9KdXd2c3hwS3ZyQmovendSS0ZPbUFhb0lZV2Jsbk4r?= =?utf-8?B?WEk3aUo5aCtPOUMvWStnckhaQ3NDWkNWOWNrRlR4d2VhUmc1b25ubkdYMGE4?= =?utf-8?B?Ry9CMGtqZFVVZWVrOGNoY0kvVzFRRmVuUGJ6dnhvMWovdmkxdDZKcHJDWUZB?= =?utf-8?B?K2ZtRUUxZE9nTURzWnNBWVJKRVZaUzJ4eW14KzZidXJrbHhBNUxEYUdFMW1H?= =?utf-8?B?M3doM3FkYVF3bkJrVUs4ZU95Mis0aGpaTnVYV1lZb2FXSTV1c1I4T2sxbmta?= =?utf-8?B?WE41VDk2R1pRbmNCTW01MUMxSjNYRXFYSGpwYml2TkoxMzQ1U1NaaDByOU0x?= =?utf-8?B?LzVFWStqekt0aFh4SU9FZzhLSjhoUFZTdGE1eE5Udmo0ckpYTFJ1TXhCVnQ5?= =?utf-8?B?WjQ2QVVaLy96TWFyWURiR0trTkhJOEgreW5YRkYvanFqVGZHQnlQL3hsVHll?= =?utf-8?B?Y2cxWDdGRVNFY2dPQ1IzajhNaWw3djhrMmV1M0dwY3dMSzRKMHMwS0JiZjNL?= =?utf-8?B?MDRabFRCRmNpVVhHbGthOTRTcGdOSEtLN3E3c0w3YzRja241ZnFtM2V2bXlw?= =?utf-8?B?UlJqUUpNbXR5RHRJWjF1UmcwRko4NXhFYVlabmdjVTdRcGlaQUt3U3NOOXV3?= =?utf-8?B?M29JNmFCR1JZZUJYUFVPWGZEYkp5Mmdvd1FvRkh4T2Z1bE5aVzh2dlBXNnhT?= =?utf-8?B?WncybVI1aXFRc3c1b3Qyc1pqcEpWVmUwOWRiWXc1RDJZVElQcGRqNzU1Zlk3?= =?utf-8?B?eUIrRVo3Q1dIaUtzeWhYS0JTaFRNWXNoS0Q5emZrSEhwTkU5VkorNVBRM2tO?= =?utf-8?Q?h82jr1DotFnmq9xpv7cE1CXCYlTulnqqAFeeW?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: e90c62eb-a7a3-406a-804c-08da23ddb31a X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 21:27:12.7355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cOQLgL5LplZfcGgbOcP0lBcjmYMQZJuIhCKivcYn6kpnhMKTYdb6uVRiIKDyR8rq1NqWLoqVqCLqUmTYwjQURnWnzfivBmr4FjCRfT/wfAKsZMWLhXBhRMR0DCpSPRQk X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR01MB7015 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220421_142719_628843_78D162CE X-CRM114-Status: GOOD ( 18.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --2088271309-883279689-1650576432=:3571 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Thu, 21 Apr 2022, Robin Murphy wrote: > On 2022-04-21 08:25, Ilkka Koskinen wrote: >> >> I still have a couple tiny comments. Otherwise the patch set looks good to >> me. >> >> On Mon, 18 Apr 2022, Robin Murphy wrote: >>> Add the identifiers and events for CMN-650, which slots into its >>> evolutionary position between CMN-600 and the 700-series products. >>> Imagine CMN-600 made bigger, and with most of the rough edges smoothed >>> off, but that then balanced out by some bonkers PMU functionality for >>> the new HN-P enhancement in CMN-650r2. >>> >>> Most of the CXG events are actually common to newer revisions of CMN-600 >>> too, so they're arguably a little late; oh well. >>> >>> Signed-off-by: Robin Murphy >>> --- >>> drivers/perf/arm-cmn.c | 222 ++++++++++++++++++++++++++++++++--------- >>> 1 file changed, 176 insertions(+), 46 deletions(-) >>> >>> diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c >>> index 9c1d82be7a2f..cce8516d465c 100644 >>> --- a/drivers/perf/arm-cmn.c >>> +++ b/drivers/perf/arm-cmn.c >>> @@ -607,12 +624,29 @@ static umode_t arm_cmn_event_attr_is_visible(struct >>> kobject *kobj, >>>     } >>> >>>     /* Revision-specific differences */ >>> -    if (cmn->model == CMN600 && cmn->rev < CMN600_R1P2) { >>> -        if (eattr->type == CMN_TYPE_HNF && eattr->eventid == 0x1b) >>> -            return 0; >>> +    if (cmn->model == CMN600) { >>> +        if (cmn->rev < CMN600_R1P3) { >>> +            if (type == CMN_TYPE_CXRA && eventid > 0x10) >>> +                return 0; >>> +        } >>> +        if (cmn->rev < CMN600_R1P2) { >>> +            if (type == CMN_TYPE_HNF && eventid == 0x1b) >>> +                return 0; >>> +            if (type == CMN_TYPE_CXRA || type == CMN_TYPE_CXHA) >>> +                return 0; >>> +        } >>> +    } else if (cmn->model == CMN650) { >>> +        if (cmn->rev < CMN650_R2P0 || cmn->rev == CMN650_R1P2) { >>> +            if (type == CMN_TYPE_HNF && eventid > 0x22) >>> +                return 0; >>> +            if (type == CMN_TYPE_SBSX && eventid == 0x17) >>> +                return 0; >>> +            if (type == CMN_TYPE_RNI && eventid > 0x10) >>> +                return 0; >>> +        } >> >> What's the plan with cmn-650 r2p0 event settings? There seem to be a few >> extra ones made visible now. I'm fine with updating this patch or taking >> care of them in a separate one, which ever makes more sense. > > arm_cmn_event_attrs *should* contain all the events supported by r2p0, with > the ones not present on earlier revisions then being filtered out here. Have > I missed anything? Note that HN-Ps don't need per-event filtering since that > node type simply doesn't exist prior to CMN-650 r2, so is already filtered by > arm_cmn_node(). Ah, I was comparing the code and perf output to HN-F and RN-I event summary tables in TRM. The tables are missing some of the events where as the event_sel register descriptions have all of them listed. So, that was my mistake and everything looks good. Cheers, Ilkka > > Thanks, > Robin. > --2088271309-883279689-1650576432=:3571 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --2088271309-883279689-1650576432=:3571--