* [PATCH] ARM: Remove unused CONFIG reference DEBUG_S3C_PORT
@ 2009-09-26 14:00 Jaswinder Singh Rajput
2009-09-26 14:03 ` Robert P. J. Day
0 siblings, 1 reply; 3+ messages in thread
From: Jaswinder Singh Rajput @ 2009-09-26 14:00 UTC (permalink / raw)
To: linux-arm-kernel
Remove unused CONFIG reference DEBUG_S3C_PORT from defconfig
Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Cc: Byungho Min <bhmin@samsung.com>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>
---
arch/arm/configs/s5pc100_defconfig | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/configs/s5pc100_defconfig b/arch/arm/configs/s5pc100_defconfig
index b0d7d3d..94edde5 100644
--- a/arch/arm/configs/s5pc100_defconfig
+++ b/arch/arm/configs/s5pc100_defconfig
@@ -859,7 +859,6 @@ CONFIG_DEBUG_ERRORS=y
# CONFIG_DEBUG_STACK_USAGE is not set
CONFIG_DEBUG_LL=y
# CONFIG_DEBUG_ICEDCC is not set
-CONFIG_DEBUG_S3C_PORT=y
CONFIG_DEBUG_S3C_UART=0
#
--
1.6.0.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: Remove unused CONFIG reference DEBUG_S3C_PORT
2009-09-26 14:00 [PATCH] ARM: Remove unused CONFIG reference DEBUG_S3C_PORT Jaswinder Singh Rajput
@ 2009-09-26 14:03 ` Robert P. J. Day
2009-09-26 15:21 ` Jaswinder Singh Rajput
0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2009-09-26 14:03 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, 26 Sep 2009, Jaswinder Singh Rajput wrote:
>
> Remove unused CONFIG reference DEBUG_S3C_PORT from defconfig
>
> Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> Cc: Byungho Min <bhmin@samsung.com>
> Cc: Ben Dooks <ben-linux@fluff.org>
> Cc: Russell King <rmk+lkml@arm.linux.org.uk>
> ---
> arch/arm/configs/s5pc100_defconfig | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/configs/s5pc100_defconfig b/arch/arm/configs/s5pc100_defconfig
> index b0d7d3d..94edde5 100644
> --- a/arch/arm/configs/s5pc100_defconfig
> +++ b/arch/arm/configs/s5pc100_defconfig
> @@ -859,7 +859,6 @@ CONFIG_DEBUG_ERRORS=y
> # CONFIG_DEBUG_STACK_USAGE is not set
> CONFIG_DEBUG_LL=y
> # CONFIG_DEBUG_ICEDCC is not set
> -CONFIG_DEBUG_S3C_PORT=y
> CONFIG_DEBUG_S3C_UART=0
no, there is no point removing redundant entries from any of the
defconfig files -- those files will eventually be rebuilt
automatically at some point.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ARM: Remove unused CONFIG reference DEBUG_S3C_PORT
2009-09-26 14:03 ` Robert P. J. Day
@ 2009-09-26 15:21 ` Jaswinder Singh Rajput
0 siblings, 0 replies; 3+ messages in thread
From: Jaswinder Singh Rajput @ 2009-09-26 15:21 UTC (permalink / raw)
To: linux-arm-kernel
Hello Robert,
On Sat, 2009-09-26 at 10:03 -0400, Robert P. J. Day wrote:
> On Sat, 26 Sep 2009, Jaswinder Singh Rajput wrote:
>
> >
> > Remove unused CONFIG reference DEBUG_S3C_PORT from defconfig
> >
> > Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> > Cc: Byungho Min <bhmin@samsung.com>
> > Cc: Ben Dooks <ben-linux@fluff.org>
> > Cc: Russell King <rmk+lkml@arm.linux.org.uk>
> > ---
> > arch/arm/configs/s5pc100_defconfig | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/configs/s5pc100_defconfig b/arch/arm/configs/s5pc100_defconfig
> > index b0d7d3d..94edde5 100644
> > --- a/arch/arm/configs/s5pc100_defconfig
> > +++ b/arch/arm/configs/s5pc100_defconfig
> > @@ -859,7 +859,6 @@ CONFIG_DEBUG_ERRORS=y
> > # CONFIG_DEBUG_STACK_USAGE is not set
> > CONFIG_DEBUG_LL=y
> > # CONFIG_DEBUG_ICEDCC is not set
> > -CONFIG_DEBUG_S3C_PORT=y
> > CONFIG_DEBUG_S3C_UART=0
>
> no, there is no point removing redundant entries from any of the
> defconfig files -- those files will eventually be rebuilt
> automatically at some point.
>
Who will build defconfig for old architectures like h3600_defconfig and
others.
If we are removing unused CONFIG from Kconfig then there is no point of
leaving those entries in defconfigs after all git grep keep those
entries and lead to confusions sooner or later. Yeah, for this case
where we have only entry in defconfig you sounds good but let
maintainers will decide it :-)
Thanks,
--
JSR
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-26 15:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-26 14:00 [PATCH] ARM: Remove unused CONFIG reference DEBUG_S3C_PORT Jaswinder Singh Rajput
2009-09-26 14:03 ` Robert P. J. Day
2009-09-26 15:21 ` Jaswinder Singh Rajput
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).