[RESENT PATCH] Don't disable irqs in set_next_event and set_mode callbacks

Thomas Gleixner
2009-11-27T22:20:11Z

On Fri, 27 Nov 2009, Russell King - ARM Linux wrote:
> On Fri, Nov 27, 2009 at 10:31:15PM +0100, Thomas Gleixner wrote:
> > On Fri, 27 Nov 2009, Russell King - ARM Linux wrote:
> > > On Fri, Nov 27, 2009 at 09:38:23PM +0100, Uwe Kleine-K?nig wrote:
> > > > OK, so this should make it save for mach-nomadik/timer.c,
> > > > mach-pxa/time.c and mach-sa1100/time.c.
> > > >
> > > > Only mach-at91/at91rm9200_time.c and mach-at91/at91sam926x_time.c
> > > > request with IRQF_SHARED | IRQF_DISABLED.
> > > > So for there the right solution is to let the local_irq_save in place
> > > > and add a comment that it is needed as the timer irq is shared.
> > > > This hopefully stopps people copying it unnecessarily.
> > >
> > > Given that the gentime code spits out warnings if its called with IRQs
> > > enabled, I don't think keeping the local_irq_save() in place is worth
> > > it - especially given Thomas' response.
> > >
> > > We've seen such warnings on AT91 (though I don't think we got positively
> > > to the bottom of it with the reporter.) If you _do_ want to ensure that
> >
> > Any pointer ?
>
> http://lists.arm.linux.org.uk/lurker/thread/20091030.165300.55a15962.en.html

That thread ends unfortunately at the point where it started to be
interesting.

I have AT91 platforms myself and we have not seen any problem at
all.

Thanks,

tglx