[PATCH] genirq: warn about IRQF_SHARED|IRQF_DISABLED at the right place

Uwe Kleine-König
2009-11-30T20:27:18Z

On Mon, Nov 30, 2009 at 12:21:30PM -0800, David Brownell wrote:
> On Monday 30 November 2009, Uwe Kleine-K?nig wrote:
> > +???????????????if (new->flags & IRQF_DISABLED)
> > +???????????????????????pr_warning("IRQ %d/%s: IRQF_DISABLED is not guaranteed "
> > +???????????????????????????????????????"on shared IRQs\n", irq, new->name);
>
> This should have copied the original test ... this way,
> it's dropping the SHARED constraint, and trying to morph
> into a generic "IRQF_DISABLED is eeebil!" test.
No, it doesn't. The inserted code is in an if block:

old_ptr = &desc->action;
old = *old_ptr;
if (old) {
/* ... */
if (!((old->flags & new->flags) & IRQF_SHARED) ||
((old->flags ^ new->flags) & IRQF_TRIGGER_MASK)) {
old_name = old->name;
goto mismatch;
}

...

+ if (new->flags & IRQF_DISABLED)
+ pr_warning("...");

and the mismatch label is further below. So the warning is still only
hit if a shared irq is registered.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |