Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 2/2] arm: Implement l2x0 cache disable functions
Date: Mon, 5 Jul 2010 13:10:56 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.1007051310230.2525@localhost.localdomain> (raw)
In-Reply-To: <1278327279.11315.23.camel@e102109-lin.cambridge.arm.com>


On Mon, 5 Jul 2010, Catalin Marinas wrote:

> On Mon, 2010-07-05 at 10:25 +0100, Thomas Gleixner wrote:
> > --- linux-2.6.orig/arch/arm/mm/cache-l2x0.c
> > +++ linux-2.6/arch/arm/mm/cache-l2x0.c
> > @@ -103,7 +103,19 @@ static void l2x0_cache_sync(void)
> >         spin_unlock_irqrestore(&l2x0_lock, flags);
> >  }
> > 
> > -static inline void l2x0_inv_all(void)
> > +static void l2x0_flush_all(void)
> > +{
> > +       unsigned long flags;
> > +
> > +       /* clean all ways */
> > +       spin_lock_irqsave(&l2x0_lock, flags);
> > +       writel(l2x0_way_mask, l2x0_base + L2X0_CLEAN_WAY);
> > +       cache_wait(l2x0_base + L2X0_CLEAN_WAY, l2x0_way_mask);
> > +       cache_sync();
> > +       spin_unlock_irqrestore(&l2x0_lock, flags);
> > +}
> 
> Since it only does cleaning, we should probably call it l2x0_clean_all
> (the same for the outer_cache_fns entry). I think on ARM we
> traditionally referred to flush as clean+invalidate.

So CLEAN_INV_WAY is the right opcode ?

Thanks,

	tglx

  reply	other threads:[~2010-07-05 11:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-05  9:25 [patch 0/2] [patch 0/2] ARM: Disable outer cache before kexec call -V2 Thomas Gleixner
2010-07-05  9:25 ` [patch 1/2] arm: Disable outer (L2) cache in kexec Thomas Gleixner
2010-07-05 10:52   ` Catalin Marinas
2010-07-05 11:13     ` Thomas Gleixner
2010-07-05 11:16       ` Catalin Marinas
2010-07-05  9:25 ` [patch 2/2] arm: Implement l2x0 cache disable functions Thomas Gleixner
2010-07-05 10:54   ` Catalin Marinas
2010-07-05 11:10     ` Thomas Gleixner [this message]
2010-07-05 11:14       ` Catalin Marinas
  -- strict thread matches above, loose matches on Subject: below --
2010-07-05 11:52 [patch 0/2] ARM: Disable outer cache before kexec call -V3 Thomas Gleixner
2010-07-05 11:52 ` [patch 2/2] arm: Implement l2x0 cache disable functions Thomas Gleixner
2010-07-05 12:13   ` Catalin Marinas
2010-08-03 12:44   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1007051310230.2525@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox