From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 00/12] arm: raw_spinlock annotations
Date: Tue, 19 Oct 2010 22:03:32 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1010192158440.6815@localhost6.localdomain6> (raw)
In-Reply-To: <20101019184433.GA10325@n2100.arm.linux.org.uk>
On Tue, 19 Oct 2010, Russell King - ARM Linux wrote:
> On Tue, Oct 19, 2010 at 05:26:45PM +0200, Arnd Bergmann wrote:
> > On Tuesday 19 October 2010, Uwe Kleine-K?nig wrote:
> > > While cleaning up my repo I refound the patches and rebased them on top
> > > of today's Linus' tree and only needed to fix up the l2x0_lock patch as
> > > in the meantime a new usage hit mainline.
> >
> > The patches all look harmless, but none of them has any information on
> > why the particular locks need to be raw_spin_lock. Ideally a raw spinlock
> > should be the absolute exception, and IMHO should have a comment in front
> > of it why it is special.
>
> Or at least explained in the patch description.
>
> For instance, can someone explain why the lock for leds and gpio stuff
> on Footbridge needs to be converted? What is the original problem?
> More importantly, what is the criteria for using a raw spinlock instead
> of a normal spinlock?
raw_spinlock is still a spinlock when PREEMPT_RT is enabled, mere
spinlocks become magically "sleeping" spinlocks (aka. PI aware
rtmutexes)
Vs. the patches: IIRC, it was all fallout from running -rt, but that
needs to be looked at case by case. Some of those are obvious as they
are called deep down in atomic irq disabled code, but others might be
just due to laziness reasons.
There is no urgency to get them merged right now.
Thanks,
tglx
next prev parent reply other threads:[~2010-10-19 20:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 13:19 [patch 00/12] arm: raw_spinlock annotations Thomas Gleixner
2010-02-17 13:21 ` [patch 01/12] arm: Convert dma_spin_lock to raw_spinlock Thomas Gleixner
2010-02-17 13:21 ` [patch 02/12] arm: Convert stop_lock " Thomas Gleixner
2010-02-17 13:21 ` [patch 03/12] arm-convert-die_lock-undef_lock-to-raw-spinlocks.patch Thomas Gleixner
2010-02-17 13:21 ` [patch 04/12] arm: Convert l2x0_lock to raw_spinlock Thomas Gleixner
2010-02-17 13:22 ` [patch 05/12] arm: Convert cpu_asid_lock " Thomas Gleixner
2010-02-17 13:22 ` [patch 06/12] arm: Convert xscale minicache_lock " Thomas Gleixner
2010-02-17 13:22 ` [patch 07/12] arm: Convert v4 " Thomas Gleixner
2010-02-17 13:23 ` [patch 08/12] arm: Convert v6_lock " Thomas Gleixner
2010-02-17 13:23 ` [patch 09/12] arm: Convert footbridge gpio and led locks " Thomas Gleixner
2010-02-17 13:23 ` [patch 10/12] arm: Convert integrator cm_lock and v3_lock " Thomas Gleixner
2010-02-17 13:23 ` [patch 11/12] arm: Convert ixp4xx pci_lock " Thomas Gleixner
2010-02-17 13:23 ` [patch 12/12] arm: Convert shark leds_lock " Thomas Gleixner
2010-10-19 14:37 ` [patch 00/12] arm: raw_spinlock annotations Uwe Kleine-König
2010-10-19 14:38 ` [PATCH 01/12] ARM: Convert dma_spin_lock to raw_spinlock Uwe Kleine-König
2010-10-19 14:38 ` [PATCH 02/12] ARM: smp: Convert stop_lock " Uwe Kleine-König
2010-10-19 14:38 ` [PATCH 03/12] ARM: Convert die_lock and undef_lock to raw_spinlocks Uwe Kleine-König
2010-10-19 14:38 ` [PATCH 04/12] ARM: Convert l2x0_lock to raw_spinlock Uwe Kleine-König
2010-10-19 14:39 ` [PATCH 05/12] ARM: Convert cpu_asid_lock " Uwe Kleine-König
2010-10-19 14:39 ` [PATCH 06/12] ARM: Convert xscale minicache_lock " Uwe Kleine-König
2010-10-19 14:39 ` [PATCH 07/12] ARM: Convert v4 " Uwe Kleine-König
2010-10-19 14:39 ` [PATCH 08/12] ARM: Convert v6_lock " Uwe Kleine-König
2010-10-19 14:39 ` [PATCH 09/12] ARM: footbridge: Convert gpio and led locks " Uwe Kleine-König
2010-10-19 14:39 ` [PATCH 10/12] ARM: integrator: Convert cm_lock and v3_lock " Uwe Kleine-König
2010-10-19 14:39 ` [PATCH 11/12] ARM: ixp4xx: Convert pci_lock " Uwe Kleine-König
2010-10-19 14:39 ` [PATCH 12/12] ARM: shark: Convert leds_lock " Uwe Kleine-König
2010-10-19 15:26 ` [patch 00/12] arm: raw_spinlock annotations Arnd Bergmann
2010-10-19 18:44 ` Russell King - ARM Linux
2010-10-19 20:03 ` Thomas Gleixner [this message]
2010-10-19 20:20 ` Arnd Bergmann
2010-10-19 22:07 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1010192158440.6815@localhost6.localdomain6 \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox