From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: resume regression in 2.6.37
Date: Thu, 13 Jan 2011 17:28:27 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1101131720350.2678@localhost6.localdomain6> (raw)
In-Reply-To: <1294933492.2535.23.camel@sven>
On Thu, 13 Jan 2011, Sven Neumann wrote:
> Now I've tried to update the kernel to 2.6.37. After fixing the already
> reported NULL pointer dereference on bootup in pxa3xx_nand_probe(), the
> device seems to work fine until I suspend it and then try to wake it up
> from suspend. Suspend seems to work fine, no warnings whatsoever.
> However there is absolutely no sign of resume.
>
> I've used git bisect to track this down to the following commit:
>
>
> commit 2f7e99bb9be6a2d8d7b808dc86037710cc8b7bf1
> Author: Thomas Gleixner <tglx@linutronix.de>
> Date: Mon Sep 27 12:45:50 2010 +0000
>
> genirq: Provide compat handling for chip->set_wake()
>
> Wrap the old chip function set_wake() until the migration is
> complete and the old chip functions are removed.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Peter Zijlstra <peterz@infradead.org>
> LKML-Reference: <20100927121842.927527393@linutronix.de>
> Reviewed-by: H. Peter Anvin <hpa@zytor.com>
> Reviewed-by: Ingo Molnar <mingo@elte.hu>
>
>
> Any idea on how to proceed from here? I don't think I can just revert
> this commit and expect things to work, right?
Well, I somehow doubt, that this is the real culprit. The patch does
not change anything of the set_wake() functionality. It's a functional
equivivalent wrapper, nothing else.
Can you revert it on top of 2.6.37 and verify that it helps ?
Thanks,
tglx
next prev parent reply other threads:[~2011-01-13 16:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 15:44 resume regression in 2.6.37 Sven Neumann
2011-01-13 16:28 ` Thomas Gleixner [this message]
2011-01-13 17:16 ` Sven Neumann
2011-01-13 17:33 ` Thomas Gleixner
2011-01-17 10:36 ` Sven Neumann
2011-01-17 12:40 ` Thomas Gleixner
2011-01-17 14:04 ` Sven Neumann
2011-01-17 18:41 ` Thomas Gleixner
2011-01-17 19:24 ` Lars-Peter Clausen
2011-01-17 19:59 ` Lars-Peter Clausen
2011-01-18 8:16 ` Sven Neumann
2011-01-18 8:18 ` [PATCH] pxa3xx: fix PXA GPIO IRQ handling Sven Neumann
2011-01-18 11:06 ` Uwe Kleine-König
2011-01-18 11:47 ` Lars-Peter Clausen
2011-01-18 12:29 ` [PATCH] ARM: pxa: fix " Sven Neumann
2011-01-18 16:15 ` [PATCH] pxa3xx: fix PXA " Eric Miao
2011-01-18 16:20 ` Lennert Buijtenhek
2011-01-18 21:49 ` Sven Neumann
2011-01-20 18:48 ` Eric Miao
2011-01-20 18:55 ` Eric Miao
2011-01-18 8:19 ` resume regression in 2.6.37 Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1101131720350.2678@localhost6.localdomain6 \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox