From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] PRUSS UIO driver support
Date: Fri, 18 Feb 2011 17:15:09 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1102181713480.2701@localhost6.localdomain6> (raw)
In-Reply-To: <201102181644.17634.arnd@arndb.de>
On Fri, 18 Feb 2011, Arnd Bergmann wrote:
> On Friday 18 February 2011, Pratheesh Gangadhar wrote:
> > Signed-off-by: Pratheesh Gangadhar <pratheesh@ti.com>
> > +static irqreturn_t pruss_handler(int irq, struct uio_info *dev_info)
> > +{
> > + return IRQ_HANDLED;
> > +}
>
> An empty interrupt handler is rather pointless. I guess you really
> notify user space when the interrupt handler gets called, as this
> is the main point of a UIO driver as far as I understand it.
The UIO core code does this for you when the driver handler returns
IRQ_HANDLED, but the empty handler raises a different questions:
Is the interrupt edge triggerd or how do you avoid an irq storm here?
Usually UIO drivers are requested to mask the interrupt in the device
itself.
Thanks,
tglx
next prev parent reply other threads:[~2011-02-18 16:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 15:05 [PATCH 0/2] Add PRUSS UIO driver support Pratheesh Gangadhar
2011-02-18 15:05 ` [PATCH 1/2] " Pratheesh Gangadhar
2011-02-18 15:05 ` [PATCH 2/2] Defines DA850/AM18xx/OMAPL1-38 SOC resources used by PRUSS UIO driver Pratheesh Gangadhar
2011-02-21 17:10 ` Sergei Shtylyov
2011-02-22 11:38 ` TK, Pratheesh Gangadhar
2011-02-18 15:44 ` [PATCH 1/2] PRUSS UIO driver support Arnd Bergmann
2011-02-18 16:15 ` Thomas Gleixner [this message]
2011-02-18 16:31 ` Arnd Bergmann
2011-02-18 17:03 ` Thomas Gleixner
2011-02-19 15:40 ` TK, Pratheesh Gangadhar
2011-02-19 18:34 ` Hans J. Koch
2011-02-21 3:57 ` TK, Pratheesh Gangadhar
2011-02-21 19:33 ` Hans J. Koch
2011-02-21 19:37 ` Thomas Gleixner
2011-02-21 19:53 ` Sergei Shtylyov
2011-02-22 12:06 ` TK, Pratheesh Gangadhar
2011-02-19 10:19 ` TK, Pratheesh Gangadhar
2011-02-18 16:31 ` Hans J. Koch
2011-02-18 17:05 ` Greg KH
2011-02-19 16:06 ` TK, Pratheesh Gangadhar
2011-02-19 11:30 ` TK, Pratheesh Gangadhar
2011-02-18 16:51 ` Thomas Gleixner
2011-02-19 12:47 ` TK, Pratheesh Gangadhar
2011-02-19 13:26 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1102181713480.2701@localhost6.localdomain6 \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox